1759590 - Add more tests for the imip-bar and itip subsytem.

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), task)

Description

[Lasana Murray]

There are various situations that can occur when receiving an invitation or an update to one. For example; the user may accept an update to an event that has been removed from the calendar. Among these scenarios exist opportunity for subtle bugs especially when changing existing behavior.

We should add some more tests so detecting breakages is easier.

Comment 1

[Lasana Murray]

Attachment: Bug 1759590 - Add tests for repeating and non-repeating events. r=#thunderbird-reviewers

Comment 2

[Lasana Murray]

Attachment: Bug 1759590 - Add tests for single updates. r=#thunderbird-reviewers

Depends on D142085

Comment 3

[Lasana Murray]

Attachment: Bug 1759590 - Add tests for updates to recurring events. r=#thunderbird-reviewers

Depends on D143803

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9168f7fa4f40
Add tests for repeating and non-repeating events. r=aleca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1742667bb401
Add tests for single updates. r=aleca
https://hg.mozilla.org/comm-central/rev/025979eaaa3b
Add tests for updates to recurring events. r=aleca

Comment 6

[Alessandro Castellani [:aleca]]

Test failures on Linux and macOS: https://treeherder.mozilla.org/logviewer?job_id=375350582&repo=comm-central&lineNumber=2951

Comment 7

[Magnus Melin [:mkmelin]]

Backed out:
https://hg.mozilla.org/comm-central/rev/31df0cdcdb6bef9be4535fd2e260494dc8a0ed10
https://hg.mozilla.org/comm-central/rev/085f49e21cb4559db0c781d350b9f0e837436ced

Comment 8

[Lasana Murray]

Attachment: Bug 1759590 - Add tests for recurring event exceptions. r=#thunderbird-reviewers

Depends on D144741

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e59fcfeb153
Add tests for single updates. r=aleca
https://hg.mozilla.org/comm-central/rev/4e45cee65075
Add tests for updates to recurring events. r=aleca

Comment 10

[Lasana Murray]

Attachment: Bug 1759590 - Add tests for accepting an exception without the parent event. r=#thunderbird-reviewers

Depends on D144757

Comment 11

[Lasana Murray]

Attachment: Bug 1759590 - Add tests for processing exceptions to events when still in "NEEDS-ACTION status. r=aleca

Depends on D145512

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f09d1d2c5a11
Add tests for recurring event exceptions. r=aleca
https://hg.mozilla.org/comm-central/rev/13cfd5d62939
Add tests for accepting an exception without the parent event. r=aleca
https://hg.mozilla.org/comm-central/rev/c522d623d5ce
Add tests for processing exceptions to events when still in "NEEDS-ACTION status. r=aleca

Comment 13

[Geoff Lankow (:darktrojan)]

I backed out the most recent commits, one of the new tests is failing quite badly. I'm pretty sure it was in the first of the three, but it's easier to take them all out and land them all again than try to merge the changes. (Also there's a typo in the last commit message you might want to fix up.)

Backout:
https://hg.mozilla.org/comm-central/rev/25d85010d36c7a13b62a89d29956a2906ff24bc5

Comment 14

[Geoff Lankow (:darktrojan)]

That wasn't meant to happen!

Comment 15

[Lasana Murray]

D144741 was supposed to land before D145813.

Comment 16

[Lasana Murray]

Please land again since D144741 has already landed.
Edit:
Or maybe it would be easier to backout https://hg.mozilla.org/comm-central/rev/25d85010d36c7a13b62a89d29956a2906ff24bc5 ?

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c1c5ab13c61
Add tests for recurring event exceptions. r=aleca
https://hg.mozilla.org/comm-central/rev/19e4ea95a978
Add tests for accepting an exception without the parent event. r=aleca
https://hg.mozilla.org/comm-central/rev/1a65436305f3
Add tests for processing exceptions to events when still in "NEEDS-ACTION status. r=aleca

Comment 18

[Lasana Murray]

Attachment: Bug 1759590 - Add tests for repeat and non-repeat cancellations. r=#thunderbird-reviewers

Comment 19

[Lasana Murray]

Attachment: Bug 1759590 - Add tests for cancelling recurring event exceptions. r=#thunderbird-reviewers

Comment 20

[Lasana Murray]

Once these last set of tests land, this can be closed. Much more testing is needed but can be done in other bugs. This forms a basic set of tests that can hopefully detect some breakage when basic changes are made to the invitation handling code.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b0af754b3b4c
Add tests for repeat and non-repeat cancellations. r=#thunderbird-reviewers,darktrojan
https://hg.mozilla.org/comm-central/rev/25ed96da509f
Add tests for cancelling recurring event exceptions. r=#thunderbird-reviewers,darktrojan

Comment 22

[Lasana Murray]

Attachment: Bug 1759590 - Request longer timeout for browser_impipBarExceptionCancel.js r=leftmostcat

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e2643b4f894
Request longer timeout for browser_impipBarExceptionCancel.js r=darktrojan