1759647 - White rectangles on Reuters after bug 1757259

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Gregory Pappas [:gregp]]

Attachment: reuters.mp4

Steps to reproduce:

Navigate to https://www.reuters.com/world/uk/my-life-will-always-be-devoted-service-uks-queen-elizabeth-says-2022-03-14/
Hover cursor over menu navigation items

Actual results:

White rectangles when transitioning

Expected results:

No white rectangles

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

I got a different regression on Windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=549deac446eba5a749957de26a2e51f5684a985c&tochange=13058b0677bb64120fb18ce0a27884db6a781cfc

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1757259

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:gw, since you are the author of the regressor, bug 1757259, could you take a look?
For more information, please visit auto_nag documentation.

Comment 5

[Glenn Watson [:gw]]

I can see what causes this - the segments can end up with an incorrect local space if the surface -> raster transform contains scale. Working on a fix for it (will involve changing how the regressing patch works to handle both these cases).

Comment 6

[Glenn Watson [:gw]]

Attachment: Bug 1759647 - Fix segments on snapped picture surface with clips + scale transform

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bfcf747cccf
Fix segments on snapped picture surface with clips + scale transform r=gfx-reviewers,nical

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3bfcf747cccf

Comment 9

[Timothy Nikkel (:tnikkel)]

Also affects pinch zooming videos on twitter for example.

Should we uplift to beta/99?

Comment 10

[Glenn Watson [:gw]]

Comment on attachment 9267986 [details]
Bug 1759647 - Fix segments on snapped picture surface with clips + scale transform

Beta/Release Uplift Approval Request

• User impact if declined: Visual glitches on some pages
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Per bug report
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change has been in nightly for a few days without any reported issues. Relatively straightforward change.
• String changes made/needed:

Comment 11

[Glenn Watson [:gw]]

Yep, it should - it's been in nighly for a few days now and I haven't seen any regressions reported. I'm not sure if it will cleanly graft to beta, let me know if not and I'll provide a rebased patch.

Comment 12

[Donal Meehan [:dmeehan]]

:gw gfx/wr/webrender/src/batch.rs does not graft cleanly to beta.
Could you please provide a rebased patch?

Comment 13

[Simona Badau, Desktop QA]

Reproduced the initial issue on Firefox 99 beta 6 on Windows 10 x64.
Verified as fixed on the latest Nightly 100.0a1 on Windows 10x64 - there are no white rectangles when viewing the menu items.

Comment 14

[Glenn Watson [:gw]]

Attachment: 0001-Bug-1759647-Fix-segments-on-snapped-picture-surface-.patch

This is a rebased patch on origin/bookbarks/beta of the unified repository.

Comment 15

[Glenn Watson [:gw]]

(In reply to Donal Meehan [:dmeehan] from comment #12)

:gw gfx/wr/webrender/src/batch.rs does not graft cleanly to beta.
Could you please provide a rebased patch?

Attached a rebased patch, this should hopefully apply cleanly.

Comment 16

[Donal Meehan [:dmeehan]]

Comment on attachment 9267986 [details]
Bug 1759647 - Fix segments on snapped picture surface with clips + scale transform

Approved for 99.0b7. Thanks.

Comment 17

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8d7207530cbe

Comment 18

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 99.0b7 on Windows 10 x64, Ubuntu 20.04 x64, and macOS Big Sur 11.6.