1759663 - X11 resource class changed to lowercase

Status: NEW

(Core :: Widget: Gtk, defect, P3)

Description

[Peder Stray]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0

Steps to reproduce:

Just started firefox

Actual results:

Window manager hints and behaviour previously working before ff98 stopped working as the x11 resource class for firefox has changed from "Firefox" to "firefox".

Expected results:

The x11 resource class should start with a capital letter.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

What exactly is broken by that change?

Comment 3

[Peder Stray]

From the X manpages: "By convention, the class name of the application is the same as the program name, but with the first letter capitalized (e.g. Bitmap or Emacs) although some programs that begin with the letter “x” also capitalize the second letter for historical reasons.", so I wonder why such a change is made since it breaks a long-standing convention.

Other than that, it will break any program that uses the X class to find firefox, since they most likely will look for "Firefox" and not "firefox". In my case, it breaks placement and other window manager specifics for firefox windows, since they look for windows with a class of "Firefox".

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Yeah, so this changed in bug 1530052. It was kind of an intentional change to make WMClass and wayland app id consistent.

Comment 5

[Jan Alexander Steffens [:heftig]]

Maybe it would be best to remove the call to gdk_set_program_class so it gets the prgname with the first character capitalized? That at least continues working with GNOME Shell, which lowercases the WMClass before looking for a matching desktop file.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1530052

Comment 7

[Jan Alexander Steffens [:heftig]]

Mike, do you have any more insight here? AFAIK Debian (and Ubuntu?) used to carry the same patches for the program name and class handling until they were upstreamed through bug 1530052, so it's a bit weird that this suddenly became a problem.

Comment 8

[Donal Meehan [:dmeehan]]

Sylvestre, do you have any input on this?

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Nope, I asked Mike and he doesn't really know either.
Is here the patches applied for the Debian packages:
https://salsa.debian.org/mozilla-team/firefox/-/tree/release/master/debian/patches

Ubuntu packages are different.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.