Closed Bug 1759690 Opened 9 months ago Closed 9 months ago

Replace AppendNativeHandler with NativeThenHandler

Categories

(Core :: DOM: Streams, task)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(5 files)

It seems all of them can be replaced as the handler classes have no special methods.

Isn't ThenWithCycleCollectedArgs semantically different than adding a promise handler, in that ThenWithCycleCollectedArgs creates a new promise as well?

Ah yes, I was thinking about "Return the result of reacting to" phrases but it seems that's used only for TransformStream algorithms.

We can still use NativeThenHandler directly, so changing the title...

Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Summary: Replace AppendNativeHandler with ThenWithCycleCollectedArgs → Replace AppendNativeHandler with NativeThenHandler

Hmm, but NativeThenHandler resolves the promise, so maybe can't be the direct replacement...

See Also: → 1759946
Attachment #9267938 - Attachment description: WIP: Bug 1759690 - Part 1: Support rejection callback on ThenWithCycleCollectedArgs → Bug 1759690 - Part 1: Support rejection callback on ThenWithCycleCollectedArgs r=smaug
Attachment #9267939 - Attachment description: WIP: Bug 1759690 - Part 2: Support ErrorResult on ThenWithCycleCollectedArgs → Bug 1759690 - Part 2: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug
Attachment #9267940 - Attachment description: WIP: Bug 1759690 - Part 3: Allow NativeThenHandler without promise to settle → Bug 1759690 - Part 3: Allow NativeThenHandler without promise to settle r=smaug
Attachment #9267941 - Attachment description: WIP: Bug 1759690 - Part 4: Use NativeThenHandler in dom/streams → Bug 1759690 - Part 4: Use NativeThenHandler in dom/streams r=mgaudet
Attachment #9267939 - Attachment description: Bug 1759690 - Part 2: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug → Bug 1759690 - Part 1: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug
Attachment #9267938 - Attachment description: Bug 1759690 - Part 1: Support rejection callback on ThenWithCycleCollectedArgs r=smaug → Bug 1759690 - Part 2: Support rejection callback on ThenWithCycleCollectedArgs r=smaug
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34e9e4bf15a4
Part 1: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug
https://hg.mozilla.org/integration/autoland/rev/6c80dea23925
Part 2: Support rejection callback on ThenWithCycleCollectedArgs r=smaug
https://hg.mozilla.org/integration/autoland/rev/809bdffb2aaf
Part 3: Allow NativeThenHandler without promise to settle r=smaug
https://hg.mozilla.org/integration/autoland/rev/277201c19ef2
Part 4: Use NativeThenHandler in dom/streams r=mgaudet

Backed out 4 changesets (Bug 1759690) for causing bustages on ReadableByteStreamController.cpp.
Backout link
Push with failures - Bb
Failure Log

Flags: needinfo?(krosylight)
Attachment #9268305 - Attachment description: WIP: Bug 1759690 - Part 5: Add Promise::Upon → Bug 1759690 - Part 4: Add a helper function for void callbacks r=mgaudet,smaug
Attachment #9267941 - Attachment description: Bug 1759690 - Part 4: Use NativeThenHandler in dom/streams r=mgaudet → Bug 1759690 - Part 5: Use lambda promise callbacks in dom/streams r=mgaudet
Flags: needinfo?(krosylight)
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb0ed6cf4ee5
Part 1: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug
https://hg.mozilla.org/integration/autoland/rev/3de41503c236
Part 2: Support rejection callback on ThenWithCycleCollectedArgs r=smaug
https://hg.mozilla.org/integration/autoland/rev/d64cb09acd5e
Part 3: Allow NativeThenHandler without promise to settle r=smaug
https://hg.mozilla.org/integration/autoland/rev/ea47234ebc00
Part 4: Add a helper function for void callbacks r=smaug
https://hg.mozilla.org/integration/autoland/rev/b8aa65badcdf
Part 5: Use lambda promise callbacks in dom/streams r=mgaudet
You need to log in before you can comment on or make changes to this bug.