Closed
Bug 1759690
Opened 2 years ago
Closed 2 years ago
Replace AppendNativeHandler with NativeThenHandler
Categories
(Core :: DOM: Streams, task)
Core
DOM: Streams
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: saschanaz, Assigned: saschanaz)
References
Details
Attachments
(5 files)
It seems all of them can be replaced as the handler classes have no special methods.
|
||
Comment 1•2 years ago
|
||
Isn't ThenWithCycleCollectedArgs semantically different than adding a promise handler, in that ThenWithCycleCollectedArgs creates a new promise as well?
|
Assignee | |
Comment 2•2 years ago
|
||
Ah yes, I was thinking about "Return the result of reacting to" phrases but it seems that's used only for TransformStream algorithms.
We can still use NativeThenHandler directly, so changing the title...
Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Summary: Replace AppendNativeHandler with ThenWithCycleCollectedArgs → Replace AppendNativeHandler with NativeThenHandler
|
|
Assignee | |
Comment 3•2 years ago
|
||
Hmm, but NativeThenHandler resolves the promise, so maybe can't be the direct replacement...
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
|
Assignee | |
Comment 5•2 years ago
|
||
Depends on D141159
|
|
Assignee | |
Comment 6•2 years ago
|
||
Depends on D141160
|
|
Assignee | |
Comment 7•2 years ago
|
||
Depends on D141161
|
||
Updated•2 years ago
|
Attachment #9267938 -
Attachment description: WIP: Bug 1759690 - Part 1: Support rejection callback on ThenWithCycleCollectedArgs → Bug 1759690 - Part 1: Support rejection callback on ThenWithCycleCollectedArgs r=smaug
|
|
||
Updated•2 years ago
|
Attachment #9267939 -
Attachment description: WIP: Bug 1759690 - Part 2: Support ErrorResult on ThenWithCycleCollectedArgs → Bug 1759690 - Part 2: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug
|
|
||
Updated•2 years ago
|
Attachment #9267940 -
Attachment description: WIP: Bug 1759690 - Part 3: Allow NativeThenHandler without promise to settle → Bug 1759690 - Part 3: Allow NativeThenHandler without promise to settle r=smaug
|
|
||
Updated•2 years ago
|
Attachment #9267941 -
Attachment description: WIP: Bug 1759690 - Part 4: Use NativeThenHandler in dom/streams → Bug 1759690 - Part 4: Use NativeThenHandler in dom/streams r=mgaudet
|
|
||
Updated•2 years ago
|
Attachment #9267939 -
Attachment description: Bug 1759690 - Part 2: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug → Bug 1759690 - Part 1: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug
|
|
||
Updated•2 years ago
|
Attachment #9267938 -
Attachment description: Bug 1759690 - Part 1: Support rejection callback on ThenWithCycleCollectedArgs r=smaug → Bug 1759690 - Part 2: Support rejection callback on ThenWithCycleCollectedArgs r=smaug
|
|
Assignee | |
Comment 8•2 years ago
|
||
Depends on D141162
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34e9e4bf15a4 Part 1: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug https://hg.mozilla.org/integration/autoland/rev/6c80dea23925 Part 2: Support rejection callback on ThenWithCycleCollectedArgs r=smaug https://hg.mozilla.org/integration/autoland/rev/809bdffb2aaf Part 3: Allow NativeThenHandler without promise to settle r=smaug https://hg.mozilla.org/integration/autoland/rev/277201c19ef2 Part 4: Use NativeThenHandler in dom/streams r=mgaudet
|
||
Comment 10•2 years ago
•
|
||
Backed out 4 changesets (Bug 1759690) for causing bustages on ReadableByteStreamController.cpp.
Backout link
Push with failures - Bb
Failure Log
Flags: needinfo?(krosylight)
|
|
||
Updated•2 years ago
|
Attachment #9268305 -
Attachment description: WIP: Bug 1759690 - Part 5: Add Promise::Upon → Bug 1759690 - Part 4: Add a helper function for void callbacks r=mgaudet,smaug
|
|
||
Updated•2 years ago
|
Attachment #9267941 -
Attachment description: Bug 1759690 - Part 4: Use NativeThenHandler in dom/streams r=mgaudet → Bug 1759690 - Part 5: Use lambda promise callbacks in dom/streams r=mgaudet
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(krosylight)
|
||
Comment 11•2 years ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb0ed6cf4ee5 Part 1: Support ErrorResult on ThenWithCycleCollectedArgs r=smaug https://hg.mozilla.org/integration/autoland/rev/3de41503c236 Part 2: Support rejection callback on ThenWithCycleCollectedArgs r=smaug https://hg.mozilla.org/integration/autoland/rev/d64cb09acd5e Part 3: Allow NativeThenHandler without promise to settle r=smaug https://hg.mozilla.org/integration/autoland/rev/ea47234ebc00 Part 4: Add a helper function for void callbacks r=smaug https://hg.mozilla.org/integration/autoland/rev/b8aa65badcdf Part 5: Use lambda promise callbacks in dom/streams r=mgaudet
|
||
Comment 12•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bb0ed6cf4ee5
https://hg.mozilla.org/mozilla-central/rev/3de41503c236
https://hg.mozilla.org/mozilla-central/rev/d64cb09acd5e
https://hg.mozilla.org/mozilla-central/rev/ea47234ebc00
https://hg.mozilla.org/mozilla-central/rev/b8aa65badcdf
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•