Closed Bug 1759754 Opened 2 years ago Closed 2 years ago

Broken "use the static preference API" link in "C++ Coding style" documentation

Categories

(Core :: Preferences: Backend, defect)

defect

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: mcomella, Assigned: janvi01)

Details

Attachments

(1 file)

I was reading through the "C++ Coding style" guide in the source tree documentation. In this section, I read:

You should use the static preference API for working with preferences.

However, the "static preference API" link is broken. We should remove it or link to the new location of the docs.

Component: General → Preferences: Backend

The severity field is not set for this bug.
:KrisWright, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(kwright)
Severity: -- → S4
Flags: needinfo?(kwright)

Hey, I would like to work on this.
Just a quick question, should I remove the link? or Should I link to the new location? (Please provide the new location)
Thanks!

Flags: needinfo?(michael.l.comella)

I don't know – :KrisWright, do you?

Flags: needinfo?(michael.l.comella) → needinfo?(kwright)

(In reply to Janvi Bajoria [:janvi01] from comment #2)

Hey, I would like to work on this.
Just a quick question, should I remove the link? or Should I link to the new location? (Please provide the new location)
Thanks!

The new libpref documentation can be found here:
https://firefox-source-docs.mozilla.org/modules/libpref/index.html

I think we could replace the broken link with this new link.

Flags: needinfo?(kwright)
Assignee: nobody → janvibajo1
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:janvi01, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(kwright)
Flags: needinfo?(janvibajo1)
Flags: needinfo?(kwright)
Pushed by kwright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12370cbe605f
fix use the static preference API link in C++ coding style documentation r=KrisWright
Flags: needinfo?(janvibajo1)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: