Closed Bug 1759782 Opened 1 year ago Closed 1 year ago

Remove Firefox Translations addon from Nightly

Categories

(Firefox :: Translation, defect)

Product:
Firefox
Component:
Translation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: anatal, Assigned: anatal)

Details

Attachments

(2 files)

Bug 1759782 - Remove Firefox Translations addon from Nightly r=mixedpuppy
48 bytes, text/x-phabricator-request
Details | Review
Patch rebased against esr 91
5.45 MB, patch
Details | Diff | Splinter Review

The current Firefox Translations bundled addon in Nightly is broken and there's no plans to replace it, so it should be removed.

Assignee: nobody → aaggarwal
Assignee: aaggarwal → anatal
Pushed by anatal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5ec640f13c6
Remove Firefox Translations addon from Nightly r=mixedpuppy

https://hg.mozilla.org/mozilla-central/rev/b5ec640f13c6

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch

Can we uplift this to ESR 91, please?

Flags: needinfo?(mixedpuppy)
Flags: needinfo?(abutkovits)
Flags: needinfo?(abutkovits) → needinfo?(ryanvm)

Feel free to submit an approval request on the patch if you feel it should be uplifted to ESR91. FWIW, it's going to need a rebased patch.

Flags: needinfo?(ryanvm) → needinfo?(anatal)

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: The bundled addon was removed from the tree and its presence on esr91 is interfering with the version being distributed on AMO: https://github.com/mozilla/firefox-translations/issues/363 and the extension's CI tests
User impact if declined: The addon is disabled on non-nightly, but its presence prevents us from running automated tests in the extension's CI.
Fix Landed on Version: 100
Risk to taking this patch (and alternatives if risky): No risks.

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Flags: needinfo?(ryanvm)
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(anatal)
Attachment #9281363 - Flags: approval-mozilla-esr91?
Attachment #9281363 - Attachment description: Patch rebased agains esr 91 → Patch rebased against esr 91

Comment on attachment 9281363 [details] [diff] [review]
Patch rebased against esr 91

We don't need this anymore. We found another way to run the tests.

Flags: needinfo?(ryanvm)
Attachment #9281363 - Flags: approval-mozilla-esr91?
You need to log in before you can comment on or make changes to this bug.