1759858 - gBrowser.tabContainer.on_drop should take into account that adoptTab can abort

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Oriol Brufau [:Oriol]]

1. Run this code in the browser console

   gBrowser.selectedTabs = [
     gBrowser.addTab("data:text/html,<title>Drag me!</title>Drag me!", {
       triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal(),
       allowInheritPrincipal: true,
       index: 0,
     }),
     gBrowser.addTab("about:preferences", {
       createLazyBrowser: true,
       triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal(),
       allowInheritPrincipal: true,
       index: 0,
     }),
   ];
   

   The 1st tab in the window will be a lazy about:preferences, the 2nd tab will be "Drag me!". Both will be multiselected, with the "Drag me!" selected.

2. Open a new window, it will have an empty tab.

3. Go back to the old window, drag the 2nd tab ("Drag me!") into the new window, into the very beginning of the tabbar.

Due to bug 1758307, the lazy tab won't be adopted into the new window.
But the new window should then have "Drag me!" as the 1st tab, and the empty tab becoming 2nd.
However, the "Drag me!" is the 2nd tab, after the empty tab, even if it was dragged before it!

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1759858 - Make gBrowser.tabContainer.on_drop handle adoptTab failures. r?Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a63c7a2d4ea
Make gBrowser.tabContainer.on_drop handle adoptTab failures. r=Gijs

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1a63c7a2d4ea