1759887 - Do not set JS hack detection if we didn't query the preferences service successfully.

Status: RESOLVED FIXED

(Firefox :: Security, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

This might be a problem...?

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1759887: Do not set JS hack detection if we didn't query the preferences service successfully r?freddyb

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

A local test following the instructions here on Windows did not cause a telemetry event to be created. Telemetry events indicate this is happening on Windows. Maybe it's a race condition I'm not triggering? But seems unlikely; given pref initialization happens on the main thread and JS Hack Detection happens on the main thread...

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1759887: Check both preference branches for values r?freddyb

This fixes a known problem where the default branch contains a
value for general.config.filename but the user branch
does not, resultnig in a Telemetry event for prefcalls.js to
be created.

However I don't think resolves all issues.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/580451a7f937
Check both preference branches for values r=freddyb

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/580451a7f937