Closed Bug 1759887 Opened 9 months ago Closed 8 months ago

Do not set JS hack detection if we didn't query the preferences service successfully.

Categories

(Firefox :: Security, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: tjr, Assigned: tjr)

Details

Attachments

(1 file, 1 obsolete file)

This might be a problem...?

Assignee: nobody → tom
Status: NEW → ASSIGNED

A local test following the instructions here on Windows did not cause a telemetry event to be created. Telemetry events indicate this is happening on Windows. Maybe it's a race condition I'm not triggering? But seems unlikely; given pref initialization happens on the main thread and JS Hack Detection happens on the main thread...

Attachment #9268103 - Attachment is obsolete: true

This fixes a known problem where the default branch contains a
value for general.config.filename but the user branch
does not, resultnig in a Telemetry event for prefcalls.js to
be created.

However I don't think resolves all issues.

Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/580451a7f937
Check both preference branches for values r=freddyb
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.