Closed
Bug 1759957
Opened 3 years ago
Closed 3 years ago
ProductAddonChecker.conservativeFetch should timeout similar to downloadXMLWithRequest
Categories
(Core :: Audio/Video: GMP, task, P1)
Core
Audio/Video: GMP
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: bryce, Assigned: bryce)
References
Details
Attachments
(1 file)
The conservativeFetch function should set a timeout for the same reasons downloadXMLWithRequest does. I.e. if we have network issues that result in timeouts, having an explicit timeout and failure path is useful not only to prevent us waiting forever, but also for being able to gather data on this happening.
I overlooked doing this in bug 1714621, and would like to get this done before bug 1739664 lands. This helps a test case for bug 1739664, which will also provide some coverage for the timeout path.
|
Assignee | |
Updated•3 years ago
|
Summary: ProductAddonChecker.conservativeFetch should timeout like similar downloadXMLWithRequest → ProductAddonChecker.conservativeFetch should timeout similar to downloadXMLWithRequest
|
|
Assignee | |
Comment 1•3 years ago
|
||
This brings the behaviour in line with what downloadXMLWithRequest does already.
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0458e8c1e761
Make conservativeFetch timeout after TIMEOUT_DELAY_MS. r=robwu
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•