1760059 - Perma browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check country - Got "US", expected "DE"

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=371394563&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OhdriRXLRxu5JnREedKFxQ/runs/0/artifacts/public/logs/live_backing.log

---

Observed both in today's beta as release simulation, so far it only failed on Windows 7 WebRender Shippable.

[task 2022-03-17T15:16:02.866Z] 15:16:02     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | Border should be transparent so that only the error outline shows - 
[task 2022-03-17T15:16:02.866Z] 15:16:02     INFO - Leaving test bound test_combined_name_fields_error
[task 2022-03-17T15:16:02.867Z] 15:16:02     INFO - Entering test bound test_hiddenFieldNotSaved
[task 2022-03-17T15:16:02.867Z] 15:16:02     INFO - expecting record retrievals: addresses
[task 2022-03-17T15:16:02.868Z] 15:16:02     INFO - Buffered messages finished
[task 2022-03-17T15:16:02.869Z] 15:16:02     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check country - Got "US", expected "DE"
[task 2022-03-17T15:16:02.869Z] 15:16:02     INFO - Stack trace:
[task 2022-03-17T15:16:02.869Z] 15:16:02     INFO - chrome://mochikit/content/browser-test.js:test_is:1422
[task 2022-03-17T15:16:02.869Z] 15:16:02     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:test_hiddenFieldNotSaved:800
[task 2022-03-17T15:16:02.870Z] 15:16:02     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | check address-level2 - 
[task 2022-03-17T15:16:02.871Z] 15:16:02     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-03-17T15:16:02.872Z] 15:16:02     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | address-level1 should not be saved - Got "ME", expected undefined
[task 2022-03-17T15:16:02.872Z] 15:16:02     INFO - Stack trace:
[task 2022-03-17T15:16:02.872Z] 15:16:02     INFO - chrome://mochikit/content/browser-test.js:test_is:1422
[task 2022-03-17T15:16:02.872Z] 15:16:02     INFO - chrome://mochitests/content/browser/browser/extensions/formautofill/test/browser/browser_editAddressDialog.js:test_hiddenFieldNotSaved:806
[task 2022-03-17T15:16:02.873Z] 15:16:02     INFO - expecting record retrievals: addresses
[task 2022-03-17T15:16:02.874Z] 15:16:02     INFO - expecting address removed
[task 2022-03-17T15:16:02.874Z] 15:16:02     INFO - expecting record retrievals: creditCards
[task 2022-03-17T15:16:02.875Z] 15:16:02     INFO - Leaving test bound test_hiddenFieldNotSaved
[task 2022-03-17T15:16:02.875Z] 15:16:02     INFO - Entering test bound test_hiddenFieldRemovedWhenCountryChanged
[task 2022-03-17T15:16:02.876Z] 15:16:02     INFO - expecting record retrievals: addresses
[task 2022-03-17T15:16:02.877Z] 15:16:02     INFO - TEST-PASS | browser/extensions/formautofill/test/browser/browser_editAddressDialog.js | no addresses at start of test - 

Comment 1

[Intermittent Failures Robot]

1 failures in 3304 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• windows7-32-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1760059&startday=2022-03-14&endday=2022-03-20&tree=all

Comment 2

[Intermittent Failures Robot]

1 failures in 3341 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1100-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1760059&startday=2022-03-21&endday=2022-03-27&tree=all

Comment 3

[Iulian Moraru]

This is permafailing now: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C11%2Cwebrender%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwith%2Cfission%2Cenabled%2Ctest-macosx1100-64-shippable-qr%2Fopt-mochitest-browser-chrome-spi-nw-fis-e10s%2Cbc3&revision=a9b419c8a9c8f73b7ae8f18ff13a92499b3a2fa4&selectedTaskRun=HOOqLQxtRfSrpT8sA_NBMA.0

Comment 4

[Iulian Moraru]

Hi Dimi! Can you please take a look at this? This is permafailing since the test got re-enabled in Bug 1717432.

Comment 5

[Intermittent Failures Robot]

25 failures in 657 pushes (0.038 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 11
• mozilla-central: 14

Platform and build breakdown:

• macosx1015-64-shippable-qr: 4
  • opt: 4
• macosx1100-64-shippable-qr: 21
  • opt: 21

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1760059&startday=2022-04-01&endday=2022-04-01&tree=all

Comment 6

[Andreea Pavel [:apavel]]

This fails only on macosx1015-64-shippable-qr and macosx1100-64-shippable-qr opt builds.

Comment 7

[Intermittent Failures Robot]

51 failures in 3323 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

This is the #15 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 25
• mozilla-central: 24
• try: 2

Platform and build breakdown:

• macosx1100-64-shippable-qr: 44
  • opt: 44
• macosx1015-64-shippable-qr: 7
  • opt: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1760059&startday=2022-03-28&endday=2022-04-03&tree=all

Comment 8

[Dimi Lee [:dimi][:dlee]]

Hi Emilio
The testcase failure on mac seems to be related to whether we reset IncrementalString of HTMLSelectEventListener.

In some of the formautofill testcase, we do the following:

1. focus on a <select> and then call synthesizeKey(xxx)
2. focus on another <select> and then call synthesizeKey(yyy)
   In the failed case, incrementalString in step2 is xxxyyy instead of yyy

I would like to know if this is something we should workaround in our formautofill test code? or this is something we want to fix in HTMLSelectEventListener. Thanks!

Example testcase code
https://searchfox.org/mozilla-central/rev/26a1b0fce12e6dd495a954c542bb1e7bd6e0d548/browser/extensions/formautofill/test/browser/browser_editAddressDialog.js#792-795

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1760059 - Make incremental search string handling local to a given element. r=dimi

Switching focus seems like a reasonable reason to start the search
again.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffb77d4ce793
Make incremental search string handling local to a given element. r=dimi

Comment 11

[Intermittent Failures Robot]

20 failures in 634 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 5
• mozilla-central: 10
• try: 1
• mozilla-beta: 4

Platform and build breakdown:

• macosx1100-64-shippable-qr: 15
  • opt: 15
• macosx1015-64-shippable-qr: 3
  • opt: 3
• macosx1015-64-devedition-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1760059&startday=2022-04-04&endday=2022-04-04&tree=all

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ffb77d4ce793

Comment 13

[Andreea Pavel [:apavel]]

This is perma-failing on mozilla-beta: https://treeherder.mozilla.org/logviewer?job_id=373444248&repo=mozilla-beta&lineNumber=5216

Comment 14

[Emilio Cobos Álvarez (:emilio)]

I guess we could uplift the fix, it's not too risky.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9270685 [details]
Bug 1760059 - Make incremental search string handling local to a given element. r=dimi

Beta/Release Uplift Approval Request

• User impact if declined: None, in practice. Fixes some perma-failures on beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward fix to make autocomplete search local to an element.
• String changes made/needed: none

Comment 16

[Dianna Smith [:diannaS]]

Comment on attachment 9270685 [details]
Bug 1760059 - Make incremental search string handling local to a given element. r=dimi

Approved for 100.0b2.

Comment 17

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3a286fd22bca

Comment 18

[Intermittent Failures Robot]

20 failures in 2922 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 10
• try: 1
• mozilla-beta: 4

Platform and build breakdown:

• macosx1100-64-shippable-qr: 15
  • opt: 15
• macosx1015-64-shippable-qr: 3
  • opt: 3
• macosx1015-64-devedition-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1760059&startday=2022-04-04&endday=2022-04-10&tree=all