1760166 - [wpt-sync] Sync PR 33169 - [block-in-inline] Prevent inline box from culling when it has block-in-inline children

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33169 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33169
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

[block-in-inline] Prevent inline box from culling when it has block-in-inline children

CL:3442958 added layout support for parallel fragmentation flows [1]
established inside a block-in-inline. NGInlineCursor didn't handle this
correctly if the inline was culled. We need to leave the parallel flow
and go back to the main flow fragmentainer and start looking for the
next object there. Otherwise we may have moved past it.

This CL fixes this issue by not culling inline boxes that have
block-in-inline children. This simplifies the code by a small perf cost
for block-in-inline.

The analysis and tests were copied from the original effort by
mstenosho@ at crrev.com/c/3483661.

[1] https://www.w3.org/TR/css-break-3/#parallel-flows

Bug: 1295183, 1301136
Change-Id: I0b3db80b934714b4a5134ca67f756f0ee0d21b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3486321
Auto-Submit: Koji Ishii \<[e-mail]>
Reviewed-by: Yoshifumi Inoue \<[e-mail]>
Commit-Queue: Yoshifumi Inoue \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#980432}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fab97609a2c18fb7c5a301ff840006f78c44634

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 4

Chrome

PASS: 4

Safari

PASS: 4

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76a2ca2d7b17
[wpt PR 33169] - [block-in-inline] Prevent inline box from culling when it has block-in-inline children, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b687cc3c9f97
[wpt PR 33169] - [block-in-inline] Prevent inline box from culling when it has block-in-inline children, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b687cc3c9f97