Some items in the context menu have icons in latest Nightly
Categories
(Firefox :: Theme, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox98 | --- | unaffected |
firefox99 | --- | unaffected |
firefox100 | --- | verified |
People
(Reporter: flod, Assigned: sfoster)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
Back, Forward, Reload, Bookmark items have an icon in the current nightly (20220317092857). Mozregression points to bug 1753767.
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1753767
Comment 3•2 years ago
|
||
:sfoster, since you are the author of the regressor, bug 1753767, could you take a look?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 4•2 years ago
|
||
The regressor seems very plausible but I can't reproduce this with the current nightly on linux or windows. What platform is that screenshot from :flod?
Assignee | ||
Comment 5•2 years ago
|
||
Can you provide more platform details and any relevant STR?
Reporter | ||
Comment 6•2 years ago
|
||
Sorry, I thought I put it in the first comment, but I didn't: macOS Monterey 12.2.1 (21D62)
That's the context menu displayed on empty space in a web page (not on links for example).
Reporter | ||
Updated•2 years ago
|
Comment 7•2 years ago
|
||
Afaics, the old %include version of the macos specific style did not include contextmenu.inc.css
.
Assignee | ||
Comment 8•2 years ago
|
||
(In reply to matthias koplenig [:metasieben] from comment #7)
Afaics, the old %include version of the macos specific style did not include
contextmenu.inc.css
.
Yeah I think that's right. So a patch like so might fix it. I don't have my mac with me today, but I can do this tomorrow if no-one has picked this up:
diff --git a/browser/themes/shared/browser-shared.css b/browser/themes/shared/browser-shared.css
--- a/browser/themes/shared/browser-shared.css
+++ b/browser/themes/shared/browser-shared.css
@@ -22,7 +22,7 @@
@import url("chrome://browser/skin/ctrlTab.css");
@import url("chrome://browser/skin/customizableui/customizeMode.css");
@import url("chrome://browser/skin/UITour.css");
-@import url("chrome://browser/skin/contextmenu.css");
+@import url("chrome://browser/skin/contextmenu.css") not (-moz-platform: macos);
@namespace html url("http://www.w3.org/1999/xhtml");
Comment 9•2 years ago
|
||
Yes, that fixes it.
Comment 10•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 11•2 years ago
|
||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 12•2 years ago
|
||
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5831da1542f Avoid loading contextmenu.css for MacOS. r=dao
Comment 13•2 years ago
|
||
bugherder |
Comment 14•2 years ago
|
||
bugherder uplift |
Comment 15•2 years ago
|
||
Reproduced with 100.0a1 (2022-03-17) and verified fixed with 100.0a1 (2022-03-28) on macOS 12.
Description
•