1760175 - Some items in the context menu have icons in latest Nightly

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Francesco Lodolo [:flod]]

Back, Forward, Reload, Bookmark items have an icon in the current nightly (20220317092857). Mozregression points to bug 1753767.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Context menu

Comment 2

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1753767

Comment 3

[Release mgmt bot [:suhaib / :marco/ :calixte]]

:sfoster, since you are the author of the regressor, bug 1753767, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Sam Foster [:sfoster] (he/him)]

The regressor seems very plausible but I can't reproduce this with the current nightly on linux or windows. What platform is that screenshot from :flod?

Comment 5

[Sam Foster [:sfoster] (he/him)]

Can you provide more platform details and any relevant STR?

Comment 6

[Francesco Lodolo [:flod]]

Sorry, I thought I put it in the first comment, but I didn't: macOS Monterey 12.2.1 (21D62)

That's the context menu displayed on empty space in a web page (not on links for example).

Comment 7

[matthias koplenig [:metasieben]]

Afaics, the old %include version of the macos specific style did not include contextmenu.inc.css.

Comment 8

[Sam Foster [:sfoster] (he/him)]

(In reply to matthias koplenig [:metasieben] from comment #7)

Afaics, the old %include version of the macos specific style did not include contextmenu.inc.css.

Yeah I think that's right. So a patch like so might fix it. I don't have my mac with me today, but I can do this tomorrow if no-one has picked this up:

diff --git a/browser/themes/shared/browser-shared.css b/browser/themes/shared/browser-shared.css
--- a/browser/themes/shared/browser-shared.css
+++ b/browser/themes/shared/browser-shared.css
@@ -22,7 +22,7 @@
 @import url("chrome://browser/skin/ctrlTab.css");
 @import url("chrome://browser/skin/customizableui/customizeMode.css");
 @import url("chrome://browser/skin/UITour.css");
-@import url("chrome://browser/skin/contextmenu.css");
+@import url("chrome://browser/skin/contextmenu.css") not (-moz-platform: macos);
 
 @namespace html url("http://www.w3.org/1999/xhtml");

Comment 9

[matthias koplenig [:metasieben]]

Yes, that fixes it.

Comment 10

[matthias koplenig [:metasieben]]

Attachment: contextmenu with patch

Comment 11

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1760175 - Avoid loading contextmenu.css for MacOS. r?Dao!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5831da1542f
Avoid loading contextmenu.css for MacOS. r=dao

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d5831da1542f

Comment 14

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1623c15e0e36

Comment 15

[Anca Soncutean [:Anca], Desktop Release QA]

Reproduced with 100.0a1 (2022-03-17) and verified fixed with 100.0a1 (2022-03-28) on macOS 12.