Closed Bug 1760209 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33198 - Ensure correct paint property state when painting floating objects

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33198 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33198
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Ensure correct paint property state when painting floating objects

Before the regression, most of paint state adjustments were done in
PaintLayerPainter. After we fixed the fundamental compositing bug by
not forcing self-painting PaintLayer for some elements and create
PaintOffsetTranslation for non-PaintLayers in more cases, the issue
of missing paint state adjustments was exposed in more cases.

This CL ensures correct paint state when painting floating objects.

Bug: 1298871
Change-Id: Ifc16af5459ad34c30059229b9d75e825c84edb75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3516735
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Commit-Queue: Xianzhu Wang \<wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981629}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a1dd8de37f7
[wpt PR 33198] - Ensure correct paint property state when painting floating objects, a=testonly
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/370ebcbb6171
[wpt PR 33198] - Ensure correct paint property state when painting floating objects, a=testonly
Regressions: 1761643

https://hg.mozilla.org/mozilla-central/rev/370ebcbb6171

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.