1760213 - [wpt-sync] Sync PR 33210 - Discard propagated float break tokens when discarding the line.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33210 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33210
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Discard propagated float break tokens when discarding the line.

Don't propagate break tokens for floats directly to
NGInlineChildLayoutContext when handling floats that get pushed below
the line. We may decide to discard the entire line and retry at a
different layout opportunity. In such cases, we'd propagate the float
break token again, and end up with duplicate fragments.

Bug: 1306811
Change-Id: I69dc2b97860f49bce1103efac8118519bf65baa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3528736
Reviewed-by: Koji Ishii \<[e-mail]>
Commit-Queue: Morten Stenshorne \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#981783}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7582ffc325117de667d4d165fec91bd1e811eae

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db240b835c3d
[wpt PR 33210] - Discard propagated float break tokens when discarding the line., a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9202e0683e3c
[wpt PR 33210] - Discard propagated float break tokens when discarding the line., a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9202e0683e3c