1760244 - Make badProtocolInclude syntactically valid

Status: RESOLVED FIXED

(Core :: IPC, task, P3)

Description

[Andrew McCreight [:mccr8]]

badProtocolInclude.ipdl is an IPDL front end unit test that includes a protocol that doesn't exist. With the Python IPDL compiler, it does correctly produce that error. However, the protocol is actually no longer syntactically valid because it does not mark its message as async. My Rust IPDL frontend checks that the file is syntactically valid before seeing if the protocol being included exists, so it emits the wrong message. I don't think we should care about the order these errors resolve in, so I'll just make the protocol syntactically valid.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1760244 - Make badProtocolInclude syntactically valid.

The Python IPDL frontend checks for includes before checking if the
entire file is syntactically valid. However, my Rust IPDL front end
does it later, so it ends up failing in a syntax error before
noticing the invalid include. I think the basic issue is that this
file wasn't updated when async was made mandatory, because it didn't
affect the results. Let's just fix the file so it only tests one
thing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fe995e782f0
Make badProtocolInclude syntactically valid. r=nika

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8fe995e782f0