1760370 - [wpt-sync] Sync PR 33263 - [FlexNG] Multi-line flex columns and margins

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33263 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33263
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[FlexNG] Multi-line flex columns and margins

Add tests for margin handling and multi-line column flex
containers. No extra code was needed to get this working. However,
while adding tests, a bug was discovered in the iterator. If we
call NextLine() while processing child break tokens, we shouldn't
set next_unstarted_item_ as that will cause a DCHECK failure.

Bug: 660611
Change-Id: I3fdcd558492d4c76de8c24777c0776ee3fd93ec2
Reviewed-on: https://chromium-review.googlesource.com/3537336
WPT-Export-Revision: 07b6260885834795c42104e4df4c4c3ce94b3dcd

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a802edf9058ceee645206f92371c15aefadd898a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

PASS: 1
FAIL: 3

Safari

PASS: 1
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/flexbox/multi-line-column-flex-fragmentation-038.html: FAIL

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-column-flex-fragmentation-037.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-038.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-039.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-040.html: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/578e473b34e9
[wpt PR 33263] - [FlexNG] Multi-line flex columns and margins, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d8f3453c8dbf
[wpt PR 33263] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb038ae73d6e
[wpt PR 33263] - [FlexNG] Multi-line flex columns and margins, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9130c2ec670f
[wpt PR 33263] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cb038ae73d6e
https://hg.mozilla.org/mozilla-central/rev/9130c2ec670f