Closed Bug 1760428 Opened 8 months ago Closed 8 months ago

[wpt-sync] Sync PR 33222 - [FlexNG] Handle break rules for multi-line columns

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33222 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33222
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Handle break rules for multi-line columns

Add support for break-before/after/inside rules for multi-line column
flex containers. Because we fragment the columns independently, we
needed a way to keep track of the break-after and early-break for each
column (tracked by NGFlexColumnBreakInfo).

We also may now have more than one early break in a given fragment, so
a way to pass in additional early breaks was added to the layout
algorithm when we abort due to an early break.

Because columns can be considered a "row" of columns, the break-before
for all first items in a column were accumulated to the container
(same with break-after and the last items in each column).

Bug: 660611
Change-Id: I198fe0543f2c89bb5d188a4e2996bec89b4546cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3531137
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#982441}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 16 tests

Status Summary

Firefox

PASS: 4
FAIL: 12

Chrome

PASS: 4
FAIL: 12

Safari

PASS: 4
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-column-flex-fragmentation-017.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-018.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-019.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-020.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-021.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-022.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-023.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-024.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-025.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-026.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-031.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-032.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b38fd8b13e5
[wpt PR 33222] - [FlexNG] Handle break rules for multi-line columns, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1f021565b256
[wpt PR 33222] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/daae58d90b4a
[wpt PR 33222] - [FlexNG] Handle break rules for multi-line columns, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d21ace0f3524
[wpt PR 33222] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.