[wpt-sync] Sync PR 33235 - Ensure animating effect paint property nodes have an output clip
Categories
(Core :: Web Painting, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33235 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33235
Details from upstream follow.
Philip Rogers <pdr@chromium.org> wrote:
Ensure animating effect paint property nodes have an output clip
This patch fixes a null deref in
|GeometryMapper::SlowLocalToAncestorVisualRectWithEffects| which assumes
an effect paint property node's output clip is present if
|EffectPaintPropertyNode::HasActiveFilterAnimation()| is true. The fix
is to use the same |EffectPaintPropertyNode::HasActiveFilterAnimation()|
check in PaintPropertyTreeBuilder when deciding whether to set an effect
node's output clip.Bug: 1304748
Change-Id: Id9fdce9d3e905fc972897cee9af4247fbe6d3320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533364
Reviewed-by: Xianzhu Wang \<wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982555}
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=abb293db6d0e52fa13d6d590263eb573b68f2281
|
|
Assignee | |
Comment 2•2 years ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS : 1
Chrome
CRASH: 1
Safari
PASS : 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8f486e6aaec [wpt PR 33235] - Ensure animating effect paint property nodes have an output clip, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1beee1c004a8 [wpt PR 33235] - Ensure animating effect paint property nodes have an output clip, a=testonly
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•