Closed Bug 1760439 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33220 - Implement FedCM permission delegates in content_shell

Categories

(Core :: DOM: Security, task, P4)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33220 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33220
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

Implement FedCM permission delegates in content_shell

Stores the permissions in memory in std::sets. This so that we can
run tests against the real implementation of fedcm instead of using
a mojo mock.

Change-Id: Ic9122a2a8454eeb7464e7106cb4906e95061468c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3529959
Reviewed-by: Yi Gu \<yigu@chromium.org>
Auto-Submit: Christian Biesinger \<cbiesinger@chromium.org>
Reviewed-by: Peter Beverloo \<peter@chromium.org>
Commit-Queue: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982711}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 33220 applied with additional changes from upstream: 9780e917a1ce6e9aaeacc2234f7365ce7548967c
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream error][domsecurity-backlog]
Whiteboard: [wptsync downstream error][domsecurity-backlog] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
FAIL: 3

Safari

OK : 1
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/credential-management/fedcm-logout.sub.https.html
logout should not throw an exception.: FAIL (Chrome: FAIL, Safari: FAIL)
logout should throw an exception when not logged in.: FAIL (Chrome: FAIL, Safari: FAIL)
logout should require a hint.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcbe1f8e140b
[wpt PR 33220] - Implement FedCM permission delegates in content_shell, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e23c0ad74ddb
[wpt PR 33220] - Implement FedCM permission delegates in content_shell, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.