Closed Bug 1760501 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33273 - Implement CSSColorValue.parse

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33273 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33273
Details from upstream follow.

Seokho Song <seokho@chromium.org> wrote:

Implement CSSColorValue.parse

Implement parse function defined in [1] using 'ConsumeColor()'
from css_parsing_utils.

Determine the color types by function type peeking the token range.
Then create a CSSColor object by the color type.

Currently, Chromium only supports to parse rgb(), rgba(), hsl(),
\<hex-color> and \<named-color>.
Therefore, This CL implements supported color functions.

[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-csscolorvalue-parse

Bug: 1303851
Change-Id: I4204ed1f3d856509a1c12227d887938fc1f56e87

Reviewed-on: https://chromium-review.googlesource.com/3522201
WPT-Export-Revision: 1bfc41445cb32c17ca82ce019b5bf4a0dd062c6b

PR 33273 applied with additional changes from upstream: 9261ca87db106c1f31f1ab4f54b8f4a2617cbc24
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 60 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
PASS : 40
FAIL : 20

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-typed-om/stylevalue-subclasses/cssColorValue.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)

Tests Disabled in Gecko Infrastructure

  • /css/css-typed-om/stylevalue-subclasses/cssColorValue.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c552fe1d2f4
[wpt PR 33273] - Implement CSSColorValue.parse, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3c552fe1d2f4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.