Closed Bug 1760610 Opened 2 years ago Closed 1 year ago

Plus (zoom in) button in zoom controls is not as tall as 100% / - (zoom out) button when in the overflow menu

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Platform:
Desktop
Unspecified
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox100 --- wontfix
firefox109 --- verified
firefox110 --- verified

People

(Reporter: Gijs, Assigned: mconley)

References

Details

Attachments

(2 files)

Zoom controls in the overflow panel
61.14 KB, image/png
Details
Bug 1760610 - Get rid of zoom-in-button icon centering hack. r?#desktop-theme-reviewers!
48 bytes, text/x-phabricator-request
Details | Review

See the composite screenshot to see what I mean.

STR:

  1. clean profile
  2. open customize mode
  3. put zoom controls in the overflow panel
  4. exit customize mode, open overflow panel
Keywords: dupeme

See also bug 1708878, not sure if this bug should be a dupe of that.

Keywords: dupeme
See Also: → 1708878
OS: macOS → Unspecified
Severity: -- → S4
Priority: -- → P3

Yeah, this seems to be caused by https://searchfox.org/mozilla-central/rev/513d9c0f27c0c3fdc9ed6c5fb222a3f90ae69d70/browser/themes/shared/toolbarbutton-icons.css#347-350.

Reading through https://phabricator.services.mozilla.com/D113727, it looks like this was originally a centering hack... if I remove the rule, at least to my eyes, I don't see a centering issue. Let's try removing it.

Assignee: nobody → mconley
Component: Toolbars and Customization → Theme
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f8d89fb75f86
Get rid of zoom-in-button icon centering hack. r=desktop-theme-reviewers,emilio,Itiel

https://hg.mozilla.org/mozilla-central/rev/f8d89fb75f86

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
QA Whiteboard: [qa-109b-p2]

Reproducible on a 2022-11-25 Nightly build on macOS 12.
Verified as fixed on Firefox 109.0b6(build ID: 20221222190305) and Nightly 110.0a1(build ID: 20221222213453) on macOS 12, Ubuntu 22, Windows 10.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-109b-p2]
status-firefox109: fixed → verified
status-firefox110: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: