Closed Bug 1760643 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33253 - [FlexNG] Multi-line flex columns and column balancing

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33253 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33253
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Multi-line flex columns and column balancing

There generally wasn't anything to update to get column balancing
working in the case of multi-line flex columns. However, the
offset adjustments we were making in the case of flex
columns was still incorrect. The reason being that we were using
the intrinsic block size of all columns, when we only wanted
the intrinsic block size of the current column.

This was fixed by moving the column intrinsic block size to
NGFlexColumnBreakInfo rather than NGFlexLine so that it is reset
in every fragmentainer. The calculation was also adjusted to
more closely match the intrinsic_block_size_ calculation.

Bug: 660611
Change-Id: I413910865ab6bab40186ced797b7b8e7863a00b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537147
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#983383}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests

Status Summary

Firefox

PASS: 1
FAIL: 4

Chrome

FAIL: 5

Safari

FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-column-flex-fragmentation-033.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-034.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/multi-line-column-flex-fragmentation-035.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-column-flex-fragmentation-039.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1713c554436c
[wpt PR 33253] - [FlexNG] Multi-line flex columns and column balancing, a=testonly
https://hg.mozilla.org/integration/autoland/rev/556f8b5a9012
[wpt PR 33253] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de9f83ca8ffc
[wpt PR 33253] - [FlexNG] Multi-line flex columns and column balancing, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3c7a836f2f48
[wpt PR 33253] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/de9f83ca8ffc
https://hg.mozilla.org/mozilla-central/rev/3c7a836f2f48

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.