Add a test that ensures that channel-prefs.js is never changed
Categories
(Toolkit :: Application Update, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: bytesized, Assigned: bytesized)
References
Details
(Whiteboard: [fidedi-ope])
Attachments
(1 file)
The channel-prefs.js file should never be changed. The reason for this is that our updater doesn't touch the file. Whatever its old contents were from before the update will be retained. So, even if we change it, its contents will only actually be changed for new installations, not for existing installations that are updated.
The updater doesn't update it for a couple of reasons. One is that QA uses this functionality during testing. Another is that Release Candidate builds have their channel (including in channel-prefs.js) set to Release. But when we deploy a Release Candidate to the Beta channel, we don't want those installations to actually use the Release channel.
Additionally, when we sign the installation for macOS, we sign it with the current version of channel-prefs.js. If, when we update, channel-prefs.js's contents do not match the contents when the package was signed, the signature won't actually validate. This is what happened in Bug 1431342. In order to make sure that that doesn't happen again, we should add a test that verifies that this file is never changed. This will ensure that no one changes it by accident and that if they try to change it on purpose, the application-update-reviewers group will be in the loop.
This should be a pretty easy test to write, so I'm going to try to have one up today or tomorrow.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
Pushed by ksteuber@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb22f8bfa91c Add a test that ensures that channel-prefs.js is never changed r=nalexander
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•