Closed Bug 1760715 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33232 - Navigation API: scrollRestoration

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox100 fixed)

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33232 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33232
Details from upstream follow.

Nate Chapin <japhet@chromium.org> wrote:

Navigation API: scrollRestoration

Explainer: https://github.com/WICG/navigation-api#scroll-position-restoration

This allows a caller of NavigateEvent.transitionWhile() to specify
whether or not the scroll position should be restored automatically
when the navigation completes (for traverse navigations). If
"scrollRestoration: 'manual'" is specified,
NavigateEvent.restoreScroll() can be used any time before the navigation
completes to immediately restore the scroll position.

Bug: 1183545
Change-Id: I47d9d756a57854a0f42787f240f93706eb551ce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500700
Reviewed-by: Domenic Denicola \<domenic@chromium.org>
Commit-Queue: Nate Chapin \<japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#983533}

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 9
FAIL : 9

Chrome

OK : 8
PASS : 2
FAIL : 7
ERROR: 1

Safari

OK : 9
FAIL : 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/navigation-api/scroll-restoration/after-transition-basic.html
scrollRestoration: after-transition should scroll when back completes: FAIL (Chrome: FAIL, Safari: FAIL)
/navigation-api/scroll-restoration/after-transition-change-history-scroll-restoration-during-promise.html
scrollRestoration: after-transition should ignore history.scrollRestoration even if it changes in the middle of the navigation: FAIL (Chrome: FAIL, Safari: FAIL)
/navigation-api/scroll-restoration/after-transition-reject.html
scrollRestoration: after-transition should not scroll when the transitionWhile promise rejects: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/scroll-restoration/after-transition-timing.html
scrollRestoration: after-transition should scroll when back completes, just before navigatesuccess: FAIL (Chrome: FAIL, Safari: FAIL)
/navigation-api/scroll-restoration/manual-basic.html
scrollRestoration: manual should prevent auto scroll on back.: FAIL (Chrome: PASS, Safari: FAIL)
/navigation-api/scroll-restoration/manual-immediate-restoreScroll.html
scrollRestoration: restoreScroll() should work inside a navigate event handler: FAIL (Chrome: FAIL, Safari: FAIL)
/navigation-api/scroll-restoration/manual-restoreScroll-after-dispatch.html
scrollRestoration: restoreScroll() should work after a navigate event dispatch: FAIL (Chrome: FAIL, Safari: FAIL)
/navigation-api/scroll-restoration/manual-restoreScroll-after-resolve.html
scrollRestoration: restoreScroll() should not work after a navigation finished promise fulfills: FAIL (Chrome: FAIL, Safari: FAIL)
/navigation-api/scroll-restoration/restoreScroll-exceptions.html
scrollRestoration: restoreScroll() should throw for a non-traverse navigation or when not in manual restoration mode: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a18fc8ada3c4 [wpt PR 33232] - Navigation API: scrollRestoration, a=testonly https://hg.mozilla.org/integration/autoland/rev/c65805ee310f [wpt PR 33232] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bced30ad4294 [wpt PR 33232] - Navigation API: scrollRestoration, a=testonly https://hg.mozilla.org/integration/autoland/rev/01cb36377bb7 [wpt PR 33232] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.