Closed Bug 1760886 Opened 2 years ago Closed 2 years ago

mozfile.remove() does not remove broken symlinks

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Version:
Default
Type:
defect

Tracking

(firefox100 fixed)

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(1 file)

Bug 1760886: Make mozfile.remove remove broken symlinks r?gbrown
48 bytes, text/x-phabricator-request
Details | Review

https://docs.python.org/3/library/os.path.html#os.path.exists says Returns False for broken symbolic links.

https://docs.python.org/3/library/os.path.html#os.path.lexists says Returns True for broken symbolic links.

I imagine that if you call mozfile.remove() on a broken symlink you still want it removed. We certainly do over in Bug 1754723.

Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5ef6197863e
Make mozfile.remove remove broken symlinks r=gbrown

https://hg.mozilla.org/mozilla-central/rev/d5ef6197863e

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
No longer blocks: 1754723
See Also: → 1760719
You need to log in before you can comment on or make changes to this bug.