1760890 - [wpt-sync] Sync PR 33308 - Revert "Create property tree nodes for will-change only when relevant property has will-change."

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33308 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33308
Details from upstream follow.

David Baron <[e-mail]> wrote:

Revert "Create property tree nodes for will-change only when relevant property has will-change."

This reverts commit 5d3dd81ee4f41ffc7fd40fda745cb097cd50e9f5.

Reason for revert: failure of fast/sub-pixel/transformed-iframe-copy-on-scroll.html on mac-mac11-arm64.

Original change's description:

Create property tree nodes for will-change only when relevant property has will-change.

Prior to this change, will-change: transform, opacity, filter, or
backdrop-filter would cause the creation of property tree nodes (in both
the paint property tree and the cc property tree) for all of them
(though only a single effect property node for both opacity and
backdrop-filter).

With this change, will-change: transform only causes the creation of a
transform node (in the transform tree), will-change: filter only causes
the creation of a filter node (in the effect tree), and will-change:
opacity or backdrop-filter only causes the creation of an effect node
(in the effect tree). However, if the nodes are created by something
else, the presence of a different will-change still causes any node that
is created in the paint property tree to be composited (i.e., created in
the cc property tree).

This provides the basis on which we can separate the transform node into
multiple transform nodes, for efficient implementation and animation of
individual transform properties, without causing a performance
regression.

Earlier versions of this CL (prior to the change that kept nodes being
composited for an unrelated will-change) caused the test
external/wpt/css/filter-effects/effect-reference-feimage-002.html to
start failing (in the same way as -001 and -003) because the filter
effect is no longer composited. It creates a copy of the test as -004
with will-change: filter rather than will-change: transform that
continues to have a composited filter effect node and thus continues
passing even with that earlier change. This test still seems worth
adding despite no longer strictly being needed.

Bug: 900241
Change-Id: I18efc630668ea7eac2a8c0a0417b766762e71d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328730
Reviewed-by: Xianzhu Wang \<[e-mail]>
Commit-Queue: David Baron \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#983821}

Bug: 900241
Change-Id: I8143ff91fa0d856ab189414e44f12ce1bcdf77e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544106
Auto-Submit: David Baron \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Owners-Override: David Baron \<[e-mail]>
Commit-Queue: David Baron \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#984017}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 33308 applied with additional changes from upstream: b94dd9d75160c92f7e444458770e2586cf12d197

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ecab1088764875341317e13f570555a4b27a387

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33176821dfa6
[wpt PR 33308] - Revert "Create property tree nodes for will-change only when relevant property has will-change.", a=testonly

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a00fe73b230
[wpt PR 33308] - Revert "Create property tree nodes for will-change only when relevant property has will-change.", a=testonly

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6a00fe73b230