1760896 - Port bug 1402822 - Spellchecker needs to allow multiple language dictionaries at the same time

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task, P1)

Description

[Geoff Lankow (:darktrojan)]

The existing spellchecker getCurrentDictionary and setCurrentDictionary methods will become getCurrentDictionaries() and setCurrentDictionaries(). We will need to port that as we use those methods in a few places: https://searchfox.org/comm-central/search?q=CurrentDictionary%28&path=mail%2F&case=false&regexp=false

Comment 1

[Magnus Melin [:mkmelin]]

Martin, can you take this?

Comment 2

[Martin Giger [:freaktechnik]]

I assume we want to keep only allowing the selection of a single dictionary for now? It seems the language selection is also coupled to other logic.

Comment 3

[Magnus Melin [:mkmelin]]

D140242 looks like it will enable selecting multiple. I'd think we should follow.

Comment 4

[Magnus Melin [:mkmelin]]

Bug 1402822 is now on autoland.

Comment 5

[Martin Giger [:freaktechnik]]

Ok, I'll provide a patch that uses the new interfaces then. Actually allowing multiple dictionaries to be selected everywhere can then be done in a less time sensitive followup enhancement.

Comment 6

[Magnus Melin [:mkmelin]]

Sounds good.

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: Bug 1760896 - Follow bug 1402822 spell checker interface changes. r=#thunderbird-reviewers

Comment 8

[Geoff Lankow (:darktrojan)]

(In reply to Martin Giger [:freaktechnik] from comment #5)

Ok, I'll provide a patch that uses the new interfaces then. Actually allowing multiple dictionaries to be selected everywhere can then be done in a less time sensitive followup enhancement.

I think it's quite likely there's already a bug for this. See if you can find it (or file a new one) and connect it to this bug.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a6a0854d76f0
Follow bug 1402822 spell checker interface changes. r=#thunderbird-reviewers,darktrojan