Closed Bug 1760907 Opened 3 years ago Closed 3 years ago

Locking OffscreenCanvasDisplayHelper's mMutex is expensive / showing in profiles

Categories

(Core :: Graphics: Canvas2D, defect, P3)

Product:
Core
Component:
Graphics: Canvas2D
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(1 file)

Bug 1760907 - Avoid mutex contention on display list updates for OffscreenCanvas.
48 bytes, text/x-phabricator-request
Details | Review

mstange showed me a profile where locking OffscreenCanvasDisplayHelper::mMutex on the main thread can be expensive when rebuilding the display list. We only need it to get the context type and the ImageContainer, both of which we could easily cache on the HTMLCanvasElement.

Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8716c6002c4 Avoid mutex contention on display list updates for OffscreenCanvas. r=gfx-reviewers,lsalzman

https://hg.mozilla.org/mozilla-central/rev/f8716c6002c4

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: