Closed Bug 1760909 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33312 - Properly remove / re-add moved children from / to the flow thread.

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33312 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33312
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Properly remove / re-add moved children from / to the flow thread.

CL:3479936 added code to notify the flow thread about descendant
removal "in time", but we forgot to notify the flow thread about the
descendants (that we're going to keep) being "re-added".

Request a full remove/insert, which will automatically call
FlowThreadDescendantWillBeRemoved() and
FlowThreadDescendantWasInserted() (in LayoutMultiColumnFlowThread) at
the right times.

Bug: 1308253, 1305865, 1308232
Change-Id: I39e0404bdc53136fa646d4664681facf0a6e35e6

Reviewed-on: https://chromium-review.googlesource.com/3541961
WPT-Export-Revision: acee0c35cdbb688c43f4873f1c6917cfa7dc15d0

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0bed59e1495
[wpt PR 33312] - Properly remove / re-add moved children from / to the flow thread., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c1ec5e69875
[wpt PR 33312] - Properly remove / re-add moved children from / to the flow thread., a=testonly

https://hg.mozilla.org/mozilla-central/rev/0c1ec5e69875

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.