1760920 - Fix multiple problems with counting memory for about:performance

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect, P1)

Description

[Paul Bone [:pbone] (PTO until 2024-09-08)]

I think that there's a problem with how the about:performance page collects memory information. It collects from a browsing context's wrapper. Which doesn't always exist meaning any JS memory is not counted. I think it's better to find the document's global object and the JS zone associated with that.

Comment 1

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 2b. Worker debugger can query the doc group r=asuth

I want to remove CollectMemoryInfo(BrowsingContext*, _) and have all callers
use the one interface with document groups. I'm not sure how correct this
WorkerDebugger code is, hopefully this is no worse.

Comment 2

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 3. Fix potential double-counting windows r=nika

Depends on D146673

Comment 3

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 4. Remove CollectMemoryInfo(RefPtr<BrowsingContext> &, _) r=nika

Remove this 2nd unnecessary code path.

Depends on D146674

Comment 4

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 5. Include memory usage from JS's malloc and JIT usage r=jonco,nika

Comment 5

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 6. Capture memory usage from the document global r=nika

Depends on D141075

Comment 6

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 8. Query memory per zone r=jonco

Since the caller usually needs to know the zone anyway, this seems simpler
if we query based on the zone rather than the object.

Depends on D146676

Comment 7

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 9. Don't count shared memory more than once r=jonco

Depends on D146677

Comment 8

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 10. Count only the media resources belonging to the document r=padenot

Depends on D146678

Comment 9

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 11. Remove dead GetTabSizes function r=nika

Depends on D146893

Comment 10

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 12. Make AddWindowTabSizes static r=nika

This function is only called from this .cpp file so it can be static.

Depends on D146894

Comment 11

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 13. Count all the JS memory for web workers r=jonco

Depends on D146895

Comment 12

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 1. Test about:performance with web workers r=florian

Comment 13

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 2a. Provide GetGCHeapUsage r=jonco

Depends on D152706

Comment 14

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 7. Add a test for memory in about:performance r=florian

Comment 15

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 14. Test that workers memory usage is reported r=florian

Depends on D150391

Comment 16

[Paul Bone [:pbone] (PTO until 2024-09-08)]

Attachment: Bug 1760920 - pt 15. Fix timing in a test leading to a failure r=florian

Sometimes this entry can be at the bottom of the table and therefore there's
no nextSibling.

Depends on D160341

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b589f7b55a27
pt 1. Test about:performance with web workers r=florian
https://hg.mozilla.org/integration/autoland/rev/274a277dbb73
pt 2a. Provide GetGCHeapUsage r=jonco
https://hg.mozilla.org/integration/autoland/rev/1400576fd80d
pt 2b. Worker debugger can query the doc group r=dom-worker-reviewers,asuth,smaug
https://hg.mozilla.org/integration/autoland/rev/9ad856e68af9
pt 3. Fix potential double-counting windows r=nika
https://hg.mozilla.org/integration/autoland/rev/41f28233dff1
pt 4. Remove CollectMemoryInfo(RefPtr<BrowsingContext> &, _) r=nika
https://hg.mozilla.org/integration/autoland/rev/34aeb07a6f67
pt 5. Include memory usage from JS's malloc and JIT usage r=jonco,nika
https://hg.mozilla.org/integration/autoland/rev/7311c284f09f
pt 6. Capture memory usage from the document global r=nika
https://hg.mozilla.org/integration/autoland/rev/09290cd6713d
pt 7. Add a test for memory in about:performance r=florian
https://hg.mozilla.org/integration/autoland/rev/822684f1df76
pt 8. Query memory per zone r=jonco
https://hg.mozilla.org/integration/autoland/rev/711128371fc0
pt 9. Don't count shared memory more than once r=jonco
https://hg.mozilla.org/integration/autoland/rev/b7cd3ed1d21b
pt 10. Count only the media resources belonging to the document r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/d702485e2dbc
pt 11. Remove dead GetTabSizes function r=nika
https://hg.mozilla.org/integration/autoland/rev/e6635f916ac9
pt 12. Make AddWindowTabSizes static r=nika
https://hg.mozilla.org/integration/autoland/rev/cebb14585723
pt 13. Count all the JS memory for web workers r=jonco
https://hg.mozilla.org/integration/autoland/rev/9d30f7b5bce0
pt 14. Test that workers memory usage is reported r=florian
https://hg.mozilla.org/integration/autoland/rev/8f02fab27335
pt 15. Fix timing in a test leading to a failure r=florian

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b589f7b55a27
https://hg.mozilla.org/mozilla-central/rev/274a277dbb73
https://hg.mozilla.org/mozilla-central/rev/1400576fd80d
https://hg.mozilla.org/mozilla-central/rev/9ad856e68af9
https://hg.mozilla.org/mozilla-central/rev/41f28233dff1
https://hg.mozilla.org/mozilla-central/rev/34aeb07a6f67
https://hg.mozilla.org/mozilla-central/rev/7311c284f09f
https://hg.mozilla.org/mozilla-central/rev/09290cd6713d
https://hg.mozilla.org/mozilla-central/rev/822684f1df76
https://hg.mozilla.org/mozilla-central/rev/711128371fc0
https://hg.mozilla.org/mozilla-central/rev/b7cd3ed1d21b
https://hg.mozilla.org/mozilla-central/rev/d702485e2dbc
https://hg.mozilla.org/mozilla-central/rev/e6635f916ac9
https://hg.mozilla.org/mozilla-central/rev/cebb14585723
https://hg.mozilla.org/mozilla-central/rev/9d30f7b5bce0
https://hg.mozilla.org/mozilla-central/rev/8f02fab27335