Closed Bug 1760933 Opened 3 years ago Closed 3 years ago

Phabricator didn't automatically close landed revisions

Categories

(Conduit :: Phabricator, defect, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: CosminS, Assigned: sheehan)

References

(Regression)

Details

(Keywords: conduit-triaged)

Attachments

(1 file)

Case of https://phabricator.services.mozilla.com/D141771 and https://phabricator.services.mozilla.com/D141769 which were landed via lando in https://lando.services.mozilla.com/D141771/ didn't get close after they're reached autoland and later on central.
Also found Bug 1562580 that is similar.
Fwiw, the revs are still opened for now.
Zeid, could you have a look at what happened here? Thank you.

Flags: needinfo?(zeid)

Yeah happened to a bunch of my revisions yesterday.

Flags: needinfo?(zeid)
Assignee: nobody → sheehan
Flags: needinfo?(emilio)

Wrote a comment, found the answer myself, forgot to unset NI. Sorry for the noise.

Flags: needinfo?(emilio)
Flags: needinfo?(dkl)
Attached file GitHub Pull Request

For completeness, I left the comment on the dupe instead of the original, but comment 1 on bug 1761228 describes the cause which was due to a new bug introduced to the differentiator extension. This bug would have affected revisions that landed after 4:35 PM ET on Tuesday March 22, 2022.

Keywords: conduit-triaged
Priority: -- → P2

This is deployed and should now be fixed. See this revision which landed via Lando and closed as expected: https://phabricator.services.mozilla.com/D141893

If you have any unclosed revisions that have already landed, please close them manually. Apologies for the inconvenience.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Regressed by: 1758000
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: