176095 - A preference references Ctrl on Mac when it should be Command

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Vincent Béron]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.0.1) Gecko/20021021
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.0.1) Gecko/20021021

The "Middle-click or control-click of links in a Web page" preference should be
"... or command-click of ..." on Mac.
The string is in locale/communicator/pref/pref-tabs.dtd, middleClick.label.
The fix should make it the same way as the next one, urlbarWinUnix.label and
urlbarMac.label.

Reproducible: Always

Steps to Reproduce:
1. Open Edit -> Preferences.
2. Navigator -> Tabs

Actual Results:  
In the second group of checkboxes, the first one says "Ctrl" on Mac.


Expected Results:  
In the second group of checkboxes, the first one should be "Command" on Mac.

Comment 1

[Vincent Béron]

Attachment: Fix for branch mozilla-1_0

Proposed patch for the branch Mozilla-1_0

Comment 2

[Matthias Versen [:Matti]]

reporter: 
pöease send a MAIL to get reviews. YOu need ar= (ask on irc) and a sr=
(www.mozilla.org/hacking)

Comment 3

[Vincent Béron]

Attachment: Fix for branch trunk

Proposed patch for the trunk

Comment 4

[jag (Peter Annema)]

Comment on attachment 103803 [details] [diff] [review]
Fix for branch trunk

I would rather see this patch go in on both the trunk and the branch. sr=jag.

Comment 5

[Vincent Béron]

Then I need to update the corresponding xul file as well, since for now it
doesn't search in the platform specific dtd in the branch 1-0. I'll attach a new
patch for branch 1-0 doing just that.

Comment 6

[Vincent Béron]

Attachment: Fix for branch mozilla-1_0 (modified files only)

This is the first part, which handles only modified files. It implements the
same thing as in the trunk. Another pacth is needed to create the proper files
fr this to work.

Comment 7

[Vincent Béron]

Attachment: Fix for branch mozilla-1_0 (new files only)

This patch creates (backports from the trunk, in fact) some files from the
en-US/mac directory. It must be used in conjonction with attachment #103860 [details] [diff] [review].

Comment 8

[jag (Peter Annema)]

Comment on attachment 103860 [details] [diff] [review]
Fix for branch mozilla-1_0 (modified files only)

sr=jag

Comment 9

[jag (Peter Annema)]

Comment on attachment 103861 [details] [diff] [review]
Fix for branch mozilla-1_0 (new files only)

sr=jag

Comment 10

[jag (Peter Annema)]

Comment on attachment 103781 [details] [diff] [review]
Fix for branch mozilla-1_0

I'd like to see the previous two patches get checked into the branch, but if it
can't be done because of l10n constraints or because drivers think it's too
risky, sr=jag on this patch, if you fix the nit pointed out below.

>Index: xpfe/components/prefwindow/resources/content/pref-tabs.xul

>+	string = document.getElementById("macMiddleClickPref");
>+	checkbox = document.getElementById("middleClick");
>+	checkbox.label = string.getAttribute("label");

Spaces, not tabs.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 103803 [details] [diff] [review]
Fix for branch trunk

a=dbaron for trunk checkin.  (Can all platforms potentially have a
middle-click?)

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 103803 [details] [diff] [review]
Fix for branch trunk

This should be tested before it is checked in, though.

Comment 13

[Vincent Béron]

Tested correctly with Mozilla 1.2b on Mac OS9.

Comment 14

[Christopher Blizzard (:blizzard)]

I still don't see a checkin message.

Comment 15

[Vincent Béron]

Who is entitled to check it in?
In other words: who should I bug?

Comment 16

[Christopher Blizzard (:blizzard)]

This has approval.  If it doesn't get checked in by the early morning tree
closure on Nov 5, 2002 it's going to have to wait until after the branch is cut.

Comment 17

[Christopher Blizzard (:blizzard)]

We're still waiting on this for the 1.2 branch.  It's going to miss the boat soon.

Comment 18

[timeless]

reporter: jag or I would check it in, but there are four attachments, and I
couldn't figure out which ones need to be committed to the branch. if you can
visit irc.mozilla.org #mozilla and contact jag or me (timeless) there, that'd be
great. if you miss us (unlikely), someone else on the channel would probably be
willing to commit it for you.

all i really need to know is which attachments to check in.

Comment 19

[jag (Peter Annema)]

None of the attachments seem to have r=, nor does this seem to have been landed
on the trunk yet.

timeless, could you r= and land this on the trunk? The same patch should (still)
pretty smoothly apply to the 1.2 branch.

Comment 20

[jag (Peter Annema)]

I think it's the second patch that would/should apply to the trunk.

Comment 21

[Vincent Béron]

Yes, it's the second one. ID=103803.

Comment 22

[Vincent Béron]

This bug has been fixed in CVS since November 2002. Should be marked Resolved/Fixed.