Closed Bug 1760977 Opened 2 years ago Closed 2 years ago

Perma [Tier 2] /builds/worker/checkouts/gecko/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp:77:27: error: loop variable 'suffix' creates a copy from type 'const nsTString<char>' [-Werror=range-loop-construct]

Categories

(Core :: DOM: Workers, defect, P5)

Product:
Core
Component:
DOM: Workers
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox98 --- unaffected
firefox99 --- unaffected
firefox100 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: akihiko.odaki)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1760977 - Do not copy nsCString in SandboxBrokerPolicyFactory.cpp r=gcp
48 bytes, text/x-phabricator-request
Details | Review

Filed by: ccozmuta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=372033559&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fJCLGTBUSaKkxeOvSrhCJA/runs/0/artifacts/public/logs/live_backing.log

[task 2022-03-23T10:14:58.553Z] 10:14:58     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/gcc/bin/g++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/7.5.0 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/x86_64-linux-gnu/c++/7.5.0 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/x86_64-linux-gnu -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include -o Unified_cpp_linux_broker0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/security/sandbox/linux/broker -I/builds/worker/workspace/obj-build/security/sandbox/linux/broker -I/builds/worker/checkouts/gecko/security/sandbox/linux -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/security/sandbox/chromium -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wc++2a-compat -Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wno-error=deprecated-copy -Wformat -Wformat-overflow=2 -Wno-psabi -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -freorder-blocks -O2 -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0/unix-print -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/at-spi2-atk/2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/at-spi-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/cairo -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/harfbuzz -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/atk-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/cairo -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pixman-1 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/freetype2 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/libpng12 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gdk-pixbuf-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/libpng12 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gio-unix-2.0/ -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/glib-2.0/include -fno-strict-aliasing  -MD -MP -MF .deps/Unified_cpp_linux_broker0.o.pp   Unified_cpp_linux_broker0.cpp
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -  In file included from Unified_cpp_linux_broker0.cpp:20:
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -  /builds/worker/checkouts/gecko/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp: In function 'void mozilla::AddMesaSysfsPaths(mozilla::SandboxBroker::Policy*)':
[task 2022-03-23T10:14:58.554Z] 10:14:58    ERROR -  /builds/worker/checkouts/gecko/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp:77:27: error: loop variable 'suffix' creates a copy from type 'const nsTString<char>' [-Werror=range-loop-construct]
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -     77 |           for (const auto suffix : kSuffixes) {
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -        |                           ^~~~~~
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -  /builds/worker/checkouts/gecko/security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp:77:27: note: use reference type to prevent copying
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -     77 |           for (const auto suffix : kSuffixes) {
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -        |                           ^~~~~~
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -        |                           &
[task 2022-03-23T10:14:58.554Z] 10:14:58     INFO -  cc1plus: all warnings being treated as errors
[task 2022-03-23T10:14:58.554Z] 10:14:58    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: Unified_cpp_linux_broker0.o] Error 1
[task 2022-03-23T10:14:58.555Z] 10:14:58     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/security/sandbox/linux/broker'
[task 2022-03-23T10:14:58.555Z] 10:14:58    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: security/sandbox/linux/broker/target-objects] Error 2
[task 2022-03-23T10:14:58.555Z] 10:14:58     INFO -  gmake[3]: *** Waiting for unfinished jobs....
[task 2022-03-23T10:14:58.555Z] 10:14:58     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/third_party/libwebrtc/modules/audio_coding/ilbc_c_gn'
[task 2022-03-23T10:14:58.555Z] 10:14:58     INFO -  mkdir -p '.deps/'
[task 2022-03-23T10:14:58.555Z] 10:14:58     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/third_party/libwebrtc/modules/audio_coding/ilbc_c_gn'
[task 2022-03-23T10:14:58.563Z] 10:14:58     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/layout/generic'
[task 2022-03-23T10:14:58.563Z] 10:14:58     INFO -  layout/generic/Unified_cpp_layout_generic4.o
[task 2022-03-23T10:14:58.563Z] 10:14:58     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/layout/generic'
[task 2022-03-23T10:14:58.658Z] 10:14:58     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/third_party/libwebrtc/modules/audio_coding/g711_gn'

Hi,

It looks like this was caused by the last changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1756087.
Push https://hg.mozilla.org/integration/autoland/rev/184fafcf0523a4706b3f765c3d901ba79b1b74ef

Can you please take a look?
Thank you!

Flags: needinfo?(akihiko.odaki)

Set release status flags based on info from the regressing bug 1756087

status-firefox100: --- → affected
status-firefox98: --- → unaffected
status-firefox99: --- → unaffected
status-firefox-esr91: --- → unaffected
Has Regression Range: --- → yes
Assignee: nobody → akihiko.odaki
Status: NEW → ASSIGNED
Flags: needinfo?(akihiko.odaki)
Pushed by gpascutto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/624ac865ee72
Do not copy nsCString in SandboxBrokerPolicyFactory.cpp r=gcp

(In reply to Noemi Erli[:noemi_erli] from comment #5)

Backed out changeset 624ac865ee72 (Bug 1760977) for causing browser-chrome failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=fQYv3g1tQi-dSOtuazdDEg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=624ac865ee72d0d75e8341f54c68ae22cd14b8b8

Log: https://treeherder.mozilla.org/logviewer?job_id=372213511&repo=autoland&lineNumber=2346

Backout: https://hg.mozilla.org/integration/autoland/rev/27176185ed0606b7790ca1799de701123b14f7bf

Looking at logs, I'm not sure if it is caused by the changeset. I read them as it is saying it failed because it couldn't find tests, but I don't think it is possible to happen because of an internal change of a C++ source file. I'm not familiar with the tests so maybe I misinterpreted the result. Can anyone else take a look at this?

[task 2022-03-24T15:31:29.509Z] 15:31:29    ERROR - No tests were found for flavor 'browser' and the following manifest filters:
[task 2022-03-24T15:31:29.510Z] 15:31:29    ERROR - skip_if, run_if, fail_if, subsuite(name=None), pathprefix(['security/sandbox/test/browser.ini'])
[task 2022-03-24T15:31:29.511Z] 15:31:29    ERROR - 
[task 2022-03-24T15:31:29.512Z] 15:31:29    ERROR - Make sure the test paths (if any) are spelt correctly and the corresponding
[task 2022-03-24T15:31:29.512Z] 15:31:29    ERROR - --flavor and --subsuite are being used. See `mach mochitest --help` for a
[task 2022-03-24T15:31:29.513Z] 15:31:29    ERROR - list of valid flavors.
[task 2022-03-24T15:31:29.513Z] 15:31:29    ERROR - 
[task 2022-03-24T15:31:29.520Z] 15:31:29     INFO - SUITE-START | Running 0 tests
[task 2022-03-24T15:31:29.520Z] 15:31:29     INFO -  TEST-INFO | checking window state
[task 2022-03-24T15:31:29.520Z] 15:31:29     INFO -  Browser Chrome Test Summary
[task 2022-03-24T15:31:29.521Z] 15:31:29     INFO -  	Passed: 0
[task 2022-03-24T15:31:29.521Z] 15:31:29     INFO -  	Failed: 0
[task 2022-03-24T15:31:29.521Z] 15:31:29     INFO -  	Todo: 0
[task 2022-03-24T15:31:29.521Z] 15:31:29     INFO -  	Mode: e10s
[task 2022-03-24T15:31:29.522Z] 15:31:29     INFO -  *** End BrowserChrome Test Results ***
[task 2022-03-24T15:31:29.522Z] 15:31:29     INFO - Buffered messages finished
[task 2022-03-24T15:31:29.522Z] 15:31:29     INFO - SUITE-END | took 0s
[task 2022-03-24T15:31:29.563Z] 15:31:29    ERROR - Return code: 1
[task 2022-03-24T15:31:29.564Z] 15:31:29    ERROR - No checks run.
[task 2022-03-24T15:31:29.564Z] 15:31:29     INFO - TinderboxPrint: mochitest-mochitest-browser-chrome<br/><em class="testfail">T-FAIL</em>
[task 2022-03-24T15:31:29.565Z] 15:31:29    ERROR - # TBPL FAILURE #
[task 2022-03-24T15:31:29.565Z] 15:31:29  WARNING - setting return code to 2
[task 2022-03-24T15:31:29.565Z] 15:31:29    ERROR - The mochitest suite: mochitest-browser-chrome ran with return status: FAILURE
Flags: needinfo?(nerli)
Flags: needinfo?(jld)
Flags: needinfo?(gpascutto)
Flags: needinfo?(akihiko.odaki)

That “no tests” failure is bug 1667271; the patch should not have been backed out.

Flags: needinfo?(jld)
Flags: needinfo?(nerli)
Flags: needinfo?(gpascutto)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11fced220175
Do not copy nsCString in SandboxBrokerPolicyFactory.cpp r=gcp

https://hg.mozilla.org/mozilla-central/rev/11fced220175

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: