1760997 - Combined items (zoom controls, clipboard cut/copy/paste controls, profiler button) are misaligned inside the Overflow Menu while in Customize page

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Anca Soncutean, Desktop QA]

Attachment: overflow menu in customize page.png

Follow up from bug 758085

Affected versions

• 100.0a1 (2022-03-22)

Affected platforms

• Windows 10
• macOS 12
• Ubuntu 20.04

Steps to reproduce

1. Go to Menu - More tools - Customize toolbar
2. Drag several items inside the Overflow Menu (make sure to include “Profiler” and “Edit Controls”)
3. Observe the Overflow Menu inside the Customize page

Expected result

• All items are aligned.

Actual result:

• “Profiler”, “Edit Controls” are not aligned with the rest of the items.

Regression range

• Regressor bug: 1747437

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1747437

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:sfoster, since you are the author of the regressor, bug 1747437, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: customize-mode-bug-1760997.png

I can't reproduce this one. This screenshot is from today's moz-central (v100), in Ubuntu. The combined items are centered rather than left aligned, but I don't think they are misaligned. :anco, can you confirm this still reproduces for you?

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: customize-mode-bug-1760997-rel-vs-nightly.png

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

I can't reproduce this one. This screenshot is from today's moz-central (v100), in Ubuntu. The combined items are centered rather than left aligned

Never mind, I see it. This is release (v98) on the left vs. nightly on the right. I'll see if there's a quick fix, but this seems relatively minor to me. Good to catch and get on file though.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1760997 - Fix alignment of combined buttons in the customize panel overflow list. r?Dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02f64b634973
Fix alignment of combined buttons in the customize panel overflow list. r=dao

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/02f64b634973

Comment 8

[Anca Soncutean, Desktop QA]

Verified fixed with the latest Nightly 100.0a1 (2022-03-30), across platforms (Windows 10, macOS 12.0, Ubuntu 20.04).