Closed Bug 1761014 Opened 2 years ago Closed 2 years ago

Intermittent TV dom/webgpu/mochitest/test_submit_compute_empty.html | Unhandled exception InvalidStateError: WebGPU is not enabled!

Categories

(Core :: Graphics: WebGPU, defect, P5)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1777098
Tracking Status
firefox-esr91 --- unaffected
firefox98 --- unaffected
firefox99 --- unaffected
firefox100 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Crash Data

Filed by: ccozmuta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=372059942&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QicmJ4P0TO6C9-T2le5lOw/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QicmJ4P0TO6C9-T2le5lOw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


[task 2022-03-23T13:05:34.084Z] 13:05:34     INFO - TEST-START | dom/webgpu/mochitest/test_submit_compute_empty.html
[task 2022-03-23T13:05:35.153Z] 13:05:35     INFO - TEST-INFO | started process screenshot
[task 2022-03-23T13:05:35.284Z] 13:05:35     INFO - TEST-INFO | screenshot: exit 0
[task 2022-03-23T13:05:35.286Z] 13:05:35     INFO - Buffered messages logged at 13:05:35
[task 2022-03-23T13:05:35.286Z] 13:05:35     INFO - TEST-PASS | dom/webgpu/mochitest/test_submit_compute_empty.html | Pref should be enabled. 
[task 2022-03-23T13:05:35.287Z] 13:05:35     INFO - Buffered messages finished
[task 2022-03-23T13:05:35.288Z] 13:05:35     INFO - TEST-UNEXPECTED-FAIL | dom/webgpu/mochitest/test_submit_compute_empty.html | Unhandled exception InvalidStateError: WebGPU is not enabled! 
[task 2022-03-23T13:05:35.288Z] 13:05:35     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-03-23T13:05:35.288Z] 13:05:35     INFO -     @dom/webgpu/mochitest/test_submit_compute_empty.html:26:19
[task 2022-03-23T13:05:35.288Z] 13:05:35     INFO - GECKO(776) | MEMORY STAT | vsize 505MB | vsizeMaxContiguous 1293MB | residentFast 45MB | heapAllocated 5MB
[task 2022-03-23T13:05:35.289Z] 13:05:35     INFO - TEST-OK | dom/webgpu/mochitest/test_submit_compute_empty.html | took 1083ms
[task 2022-03-23T13:05:35.289Z] 13:05:35     INFO - TEST-START | Shutdown
Summary: Intermittent dom/webgpu/mochitest/test_submit_compute_empty.html | Unhandled exception InvalidStateError: WebGPU is not enabled! → Intermittent TV dom/webgpu/mochitest/test_submit_compute_empty.html | Unhandled exception InvalidStateError: WebGPU is not enabled!

:aosmond, since you are the author of the regressor, bug 1760810, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(aosmond)

Set release status flags based on info from the regressing bug 1760810

Crash Signature: [@ wgpu_core::hub::Storage<T,I>::get]
Has Regression Range: --- → yes

I guess what happened is we set dom.webgpu.enabled without restarting the process. At startup we queried the pref while it was false:

https://searchfox.org/mozilla-central/rev/be4604e4be8c71b3c1dbff2398a5b05f15411673/gfx/thebes/gfxPlatform.cpp#2769

Which caused us to trip when it was later enabled:

https://searchfox.org/mozilla-central/rev/be4604e4be8c71b3c1dbff2398a5b05f15411673/dom/webgpu/Instance.cpp#56

Because we don't create the child if the gfxVar is false:

https://searchfox.org/mozilla-central/rev/be4604e4be8c71b3c1dbff2398a5b05f15411673/dom/webgpu/Instance.cpp#26

I think the fix ultimately will be to just turn flip dom.webgpu.enabled to true for tests in general so that we don't have this problem.

Crash Signature: [@ wgpu_core::hub::Storage<T,I>::get]
Flags: needinfo?(aosmond)
Crash Signature: [@ wgpu_core::hub::Storage<T,I>::get]
See Also: → 1761387
See Also: → 1769788
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.