1761055 - Implement support for blocking usual non-best-match Firefox Suggest suggestions

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

We need to re-enable best match suggest blocking.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1761055 - Implement support for blocking usual non-best-match Firefox Suggest suggestions.

This revision does the following:

• Add a new Nimbus variable quickSuggestBlockingEnabled with a fallback pref
  to show the block button on the usual non-best-match quick suggest rows.
• Previously we supported the block button only on best match rows. This keeps
  that, and it also adds a Nimbus variable bestMatchBlockingEnabled for it.
  We only had a pref for it.
• Change the name of the browser.urlbar.quickSuggest.blockedDigests pref to
  browser.urlbar.quicksuggest.blockedDigests -- i.e., "quicksuggest" should be
  in all lowercase, not camel case, since that's what all quick suggest prefs
  use. We don't need to worry about a pref migration because blocking has never
  been enabled.
• When setting the browser.urlbar.quicksuggest.blockedDigests pref, ignore the
  resulting onPrefChanged() listener call. I do this by keeping a new
  _updatingBlockedDigests property, similar to _updatingImpressionStats
  added in D142152.
• Copy the browser_quicksuggest_bestMatch.js test to a new
  browser_quicksuggest_block.js test that is specifically for testing blocking.
  The new test checks both usual quick suggest rows and best matches.

Depends on D142780

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4f9696e17c6
Implement support for blocking usual non-best-match Firefox Suggest suggestions. r=daisuke

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c4f9696e17c6

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 101.0a1 build (Build ID: 20220414092955) on Windows 10 x64, macOS 11.6 and Linux Mint 20 x64. In order to test this I have set the "browser.search.region" to "US" and "browser.urlbar.quicksuggest.blockingEnabled" to true.

• The "Dismiss" button is correctly displayed for non-best-match Firefox Suggest suggestions.
• The dismissed suggestions are no longer redisplayed.
• If the "browser.urlbar.quicksuggest.blockedDigests" pref is deleted the dismissed suggestions are correctly re-displayed.

I have also verified the dismiss functionality for the Best Match results. In order to do this we have changed the following prefs:
"browser.urlbar.bestMatch.enabled" to "true" and "browser.urlbar.bestMatch.blockingEnabled" to "true".

• The "Dismiss" button is correctly displayed for the Best Match suggestions.
• The dismissed suggestions are no longer redisplayed.
• If the "browser.urlbar.quicksuggest.blockedDigests" pref is deleted the dismissed suggestions are correctly re-displayed.