Closed Bug 1761110 Opened 3 years ago Closed 3 years ago

Add tests for PiPToggleChild video wrapper

Categories

(Toolkit :: Picture-in-Picture, task, P1)

Product:
Toolkit
Component:
Picture-in-Picture
Type:
task
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: kpatenio, Assigned: kpatenio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-MR1-2022])

Attachments

(1 file)

Bug 1761110 - Add tests for video wrapper method shouldHideToggle. r=#pip-reviewers!
48 bytes, text/x-phabricator-request
Details | Review

Following Bug 1757921, it would be nice to have a test for PiPToggleChild, especially considering that the patch applies the video wrapper to both PiPToggleChild and PictureInPictureChild. The one method we'd need to test in particular is shouldHideToggle().

Place to add this test would be browser/extensions/pictureinpicture/tests/browser

See Also: → 1757927, 1759603
See Also: 1757927 → 1757921
Depends on: 1757921
See Also: 1757921 →
Whiteboard: [fidefe-MR1-2022]
Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P1
Points: --- → 2
Attachment #9269743 - Attachment description: WIP: Bug 1761110 - Add tests for video wrapper method shouldHideToggle. r=#pip-reviewers! → Bug 1761110 - Add tests for video wrapper method shouldHideToggle. r=#pip-reviewers!
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96575cec828d Add tests for video wrapper method shouldHideToggle. r=pip-reviewers,mhowell

https://hg.mozilla.org/mozilla-central/rev/96575cec828d

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: