Closed Bug 1761158 Opened 2 years ago Closed 2 years ago

datetimebox calls addEventListener for "mousedown" in destructor

Categories

(Toolkit :: UI Widgets, defect, P2)

defect

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: jdescottes, Assigned: hjones)

Details

Attachments

(1 file)

Was trying to use the input type=date in browser mochitests, but it seems to leak for various reasons.

While looking at that I spotted the following line in the destructor which seems wrong:
https://searchfox.org/mozilla-central/rev/630b197be00e3df3f2e3fe995bf31ca50d146eaa/toolkit/content/widgets/datetimebox.js#54

    this.mResetButton.addEventListener("mousedown", this, {
      mozSystemGroup: true,
    });

This should be removeEventListener most likely?

Severity: -- → S3
Priority: -- → P2
Assignee: nobody → hjones
Status: NEW → ASSIGNED
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0e59ceee952
fix addEventListener call in datetimebox destructor r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: