1761240 - [traceback] ValueError: invalid literal for int() when parsing linux os_version

Status: RESOLVED FIXED

(Socorro :: Processor, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sentry: https://sentry.prod.mozaws.net/operations/socorro-new-stage/issues/19453153/

Traceback:

ValueError: invalid literal for int() with base 10: '17-0'
  File "socorro/processor/processor_pipeline.py", line 278, in process_crash
    rule.act(raw_crash, dumps, processed_crash, processor_meta_data)
  File "socorro/processor/rules/base.py", line 63, in act
    self.action(raw_crash, dumps, processed_crash, processor_meta_data)
  File "socorro/processor/rules/mozilla.py", line 1041, in action
    minor_version = int(version_split[1])

os_version at this point is:

'5.17-0.1 #2 SMP PREEMPT Mon, 21 Mar 2022 08:37:24 +0000'

That splits on . so then minor version ends up as 17-0 which isn't an int.

Maybe we switch the parsing to use a regex like ^(\d+)\.(\d+) as a first pass for major/minor figuring?

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Here's an example crash report: bp-d1d924a8-ac56-432f-8f59-5bc4c0220324

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Here's another example report: bp-1ba2befd-1909-4e35-907f-d34f60220406

'3.14-2-686-pae #1 SMP Debian 3.14.15-2 (2014-08-09)'

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6068: bug 1761240: fix major/minor version figuring

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6068: "bug 1761240: fix major/minor version figuring" in 6b0754a.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this to production in bug #1764141. Marking as FIXED.