Closed Bug 1761245 Opened 6 months ago Closed 6 months ago

[RTL] Reader Mode displays two identical themes with different text

Categories

(Toolkit :: Reader Mode, defect)

Firefox 99
Desktop
All
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: oana.ardelean, Unassigned)

Details

Attachments

(1 file)

Attached image screenshot

Preconditions
Use an RTL build(ar/he).

Affected versions
99.0b7

Affected platforms
macOS 11
Windows 7 x 64
Windows 11
Ubuntu 20.04

Steps to reproduce

  1. Launch Firefox and go to https://longform.org/best .
  2. Click on the Reader view icon from the Menu bar.
  3. Click on the "Type Controls" button.

Expected result
There should be 3 themes to choose from: Light, Sepia and Dark.

Actual result
There are 4 themes.

Regression range
Will look for one ASAP.

Attachments
There is a screenshot showing the problem in more detail.

Notes
In this particular case i tested on macOS with Dark Theme enabled at OS level; as such, 2 different Dark Mode buttons are showing. On win7, the test was done using Light Theme at OS level; 2 different Light mode buttons are showing. See the attachment for more detail.

Severity: -- → S4
OS: Unspecified → All

I don't think this is necessarily a bug. The default prefs for the color schemes include an "Auto" option. And if you look at the Arabic text in your screenshot, while I can't read Arabic myself, I can see that the text for the two buttons showing the same color indeed have different labels.

So some locales / setups may only show three, it's possible that some may also show four.

Note also, this comment:
// (auto only works on platforms where the 'devicelight' event is enabled)
https://searchfox.org/mozilla-central/rev/3f782c2587124923a37c750b88c5a40108077057/modules/libpref/init/all.js#4173

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.