Open Bug 1761253 Opened 3 years ago Updated 2 years ago

Failure to find broken formatting with "mach lint --outgoing --warnings --fix"

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(Not tracked)

People

(Reporter: gerard-majax, Unassigned)

Details

This was popping https://phabricator.services.mozilla.com/D140744?id=559927#C4924987NL335:

Lint: clang-format
WARNING: The change does not follow the C/C++ coding style, please reformat

  MOZ_ASSERT(mSandboxTestingParents.IsEmpty(),
             "Cleared all SandboxTestingParents");

However, a local mach lint --outgoing --warnings --fix on the very same commit would not identify the issue yet a mach lint --warnings --fix security/sandbox/common/test/SandboxTest.cpp would do it successfully.

As much as I can tell --outgoing was behaving correctly otherwise.

Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.