Closed Bug 1761261 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33350 - Return an empty font list when the permission is not given, or platform implementation is missing (e.g. Android).

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox100 fixed)

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33350 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33350
Details from upstream follow.

Daseul Lee <dslee@chromium.org> wrote:

Return an empty font list when the permission is not given, or platform implementation is missing (e.g. Android).

Previously in the case of unsupported platform, the browser-side code returned FontEnumerationStatus::kUnexpectedError, while the renderer side handled FontEnumerationStatus::kUnimplementedError even though it would never been thrown under any case. We fix that behavior by updating the browser-side to throw an UnimplementedError, which the renderer handles by returning an empty font list. In general, the browser-side will provide specific information about font enumeration status, and the renderer-side will handle how users will receive the response. Similarly for permission denied or not given cases, the renderer-side will process FontEnumerationStatus::kPermissionDenied into an empty font list.

Bug: 1296792
Change-Id: I5c936a176d49453d3494bbc952831f83512c7db4
Reviewed-on: https://chromium-review.googlesource.com/3547299
WPT-Export-Revision: c82554f48aac3ebd2a348086bfca28843c12351a

PR 33350 applied with additional changes from upstream: 4a4255c8eb6d934f403996a1bdd28108b1e3b791
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 3 subtests

Status Summary

Firefox

OK : 5[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 6[GitHub]
FAIL: 20[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 23[GitHub]

Chrome

OK : 6
FAIL: 23

Safari

OK : 6
FAIL: 23

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/font-access/font_access_basic.tentative.https.window.html
font_access_basic: FAIL (Chrome: FAIL, Safari: FAIL)
/font-access/font_access_blob.tentative.https.window.html
font_access_blob: FAIL (Chrome: FAIL, Safari: FAIL)
/font-access/font_access_permission.tentative.https.window.html
query(): permission not given: FAIL (Chrome: FAIL, Safari: FAIL)
query(): permission denied: FAIL (Chrome: FAIL, Safari: FAIL)
query(): permission granted: FAIL (Chrome: FAIL, Safari: FAIL)
/font-access/font_access_query_select.tentative.https.window.html
font_access_query_select: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 1: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 2: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 3: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 4: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 5: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 6: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 7: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 8: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 9: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 10: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 11: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 12: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_query_select 13: FAIL (Chrome: FAIL, Safari: FAIL)
/font-access/font_access_sorted.tentative.https.window.html
font_access_sorted: FAIL (Chrome: FAIL, Safari: FAIL)
/font-access/font_access_detached_iframe.tentative.https.window.html
font_access_detached_iframe: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_detached_iframe 1: FAIL (Chrome: FAIL, Safari: FAIL)
font_access_detached_iframe 2: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/331d3a27899e
[wpt PR 33350] - Return an empty font list when the permission is not given, or platform implementation is missing (e.g. Android). Also, remove the unused kCanceled status., a=testonly

https://hg.mozilla.org/mozilla-central/rev/331d3a27899e

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.