1761299 - Profiler markers disappear when increasing the window width

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Florian Quèze [:florian]]

Attachment: Profile correctly displayed

I only tried to reproduce this on Mac. I can only reproduce on my external 27" screen. I can't reproduce the bug at these resolutions: 3840x2160, 1920x1060. I can reproduce at these resolutions: 2560x1440, 3008x1692, 3360x1890.

It seems to me the bug happens when the scaling factor isn't an integer.

I can mozregression, which gave https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e981d54aa148bd2d73f0f8f8ac4e90b13420a77f&tochange=3c3520362bda55a31840d9a4ed3a6cc9bb097cfd, ie. bug 1757876.

The steps I used to reproduce: load https://profiler.firefox.com/public/3c9tta4gkh0k5nr0jkhcg0mza7vfh38yree4rtg/ and maximize the window. See that some markers disappear when the window is large. For some reason, the markers of the selected track still appear.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1757876

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:gw, since you are the author of the regressor, bug 1757876, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Florian Quèze [:florian]]

Attachment: Profiler markers missing in a larger window

Notice the missing red and black rectangles.

Comment 4

[Markus Stange [:mstange]]

I can reproduce this. And after using my browser at this wide width for a while, I even noticed another bug that only happens with >= 4096 dev pixel window widths, this time involving video!
On YouTube, in "Theater mode" (so that the video controls span the entire width of the page), while a video is playing, hovering the video makes the video controls appear with a delay. There's a shadow at the bottom of the video that appears instantly, but the controls on top of the shadow appear later. With a narrow window, both the shadow and the controls appear at the same time, with an animation.

Comment 5

[Markus Stange [:mstange]]

Both bugs happen regardless of the value of the pref gfx.webrender.compositor.

Comment 6

[Glenn Watson [:gw]]

It doesn't occur in a default build for me, but I can reproduce it immediately if I change the value of MAX_SURFACE_SIZE to be 2048 or 1024, so it does seem related to that.

Comment 7

[Glenn Watson [:gw]]

Attachment: Bug 1761299 - Fix raster spatial node indices being out of sync

When the max surface size is exceeded, the raster spatial node
for a given surface is adjusted in get_surface_rects. However
a locally cached variable of the old raster spatial node index
was being used as a parameter when creating the render task.

Instead, only retrieve the raster spatial node after the call to
get_surface_rects, ensuring that it gets the updated value.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b9aede36b94
Fix raster spatial node indices being out of sync r=gfx-reviewers,nical

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3b9aede36b94

Comment 10

[Glenn Watson [:gw]]

Comment on attachment 9269321 [details]
Bug 1761299 - Fix raster spatial node indices being out of sync

Beta/Release Uplift Approval Request

• User impact if declined: Visual glitches on some pages, mostly when zooming
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is a simple fix for a clear bug. If it doesn't graft cleanly, I can manually rebase it, but it's quite small.
• String changes made/needed:

Comment 11

[Marco Castelluccio [:marco]]

Glenn, the regressor (bug 1757876) landed in 100 and the fix in this bug also landed in 100. Why is an uplift needed to 99?

Comment 12

[Glenn Watson [:gw]]

Oh, you're right - I've cleared the uplift request. Thanks.