Closed
Bug 1761369
Opened 2 years ago
Closed 2 years ago
mochitest profiles captured with --profiler should include content child processes
Categories
(Core :: Gecko Profiler, enhancement, P2)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
100 Branch
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
Mochitest profiles in optimized builds (which use Cu.exitIfInAutomation
to shutdown faster once the test is finished) only contain the parent process profile. In browser chrome mochitests this is often not enough, and in plain mochitests this is never enough as the test actually runs in a content process.
I think the easiest way to fix this is to reimplement in JS the logic currently implemented in profiler_shutdown
in C++ to do a full async capture of the profile before the exit 0.
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Example profiles:
- Browser chrome mochitest: before / after (
mach test browser/base/content/test/performance/browser_tabclose.js --profiler
) - Plain mochitests: before / after (
mach test dom/abort/tests --profiler
)
xpcshell tests are not affected because we avoid calling exitIfInAutomation
if the test runs in a child process.
Severity: -- → N/A
Priority: -- → P2
Summary: mochitest profiles captured with --profiler should content child processes → mochitest profiles captured with --profiler should include content child processes
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1da49b17c303 Record child process profiles in mochitest profiles captured using --profiler, r=gerald.
Comment 4•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•