Closed Bug 1761390 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33362 - [FlexNG] OOF handling and fragmentation

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33362 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33362
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] OOF handling and fragmentation

Similar to CL:3448032, add OOFs to the last flex fragment so that
the static position can be calculated correctly in the case of
fragmentation.

A vector of OOF children was added to the flex break token so that
we don't have to loop back over all children to find the OOFs.
The border_scrollbar_padding_block_offset was added to the break
token as well since that gets set to 0 when an element fragments.
We need to know the original value in order to properly calculate
the static positions.

Note: While adding tests, I noticed that we don't add the expansion
from the last row to the intrinsic block size. This will be
investigated in a follow-up CL with OOF-related tests.

Bug: 660611
Change-Id: Ic360499085fb7e544fa9a0f1da100933f5e8a82c

Reviewed-on: https://chromium-review.googlesource.com/3551497
WPT-Export-Revision: 82e375247da9bb429c862ea43938392444180ee3

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

FAIL: 6

Chrome

PASS: 5
FAIL: 1

Safari

PASS: 3
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/flexbox/multi-line-column-flex-fragmentation-045.html: FAIL
/css/css-break/flexbox/multi-line-row-flex-fragmentation-051.html: FAIL
/css/css-break/flexbox/single-line-column-flex-fragmentation-042.html: FAIL

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-column-flex-fragmentation-045.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/multi-line-row-flex-fragmentation-051.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/single-line-column-flex-fragmentation-041.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-break/flexbox/single-line-column-flex-fragmentation-042.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/flexbox/single-line-column-flex-fragmentation-043.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/flexbox/single-line-row-flex-fragmentation-028.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0df58de8bc5d
[wpt PR 33362] - [FlexNG] OOF handling and fragmentation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dabad0487a37
[wpt PR 33362] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0df58de8bc5d
https://hg.mozilla.org/mozilla-central/rev/dabad0487a37

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.