1761432 - Tidy up the script load request's progress enum

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jon Coppeard (:jonco)]

There's a couple of oddities about the way this works. There's a separate 'cancelled' boolean that really should be part of this state. Also it includes a state for when we're requesting source only (rather than bytecode) that would be better handled by a separate flag.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1761432 - Part 1: Rename ScriptLoadRequest progress enum to 'State' r?smaug

This also renames 'loading' enum values to 'fetching' since this is more
specific. Loading covers the whole process of loading, which includes the other
states.

Enum values have the leading 'e' removed in line with the coding style for enum
classes.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1761432 - Part 2: Split out script load request state for when we require loading from source r?smaug

This is used when we explicitly don't want to load cached bytecode. It is
better served by a separate flag in the request than a state.

Depends on D142041

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1761432 - Part 3: Add script load request cancelled state r?smaug

Previously a separate field, this makes more sense as a state in its own right.

Depends on D142042

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1761432 - Part 4: Rename state accessor methods after the enum values r?smaug

Depends on D142043

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c5d8b97d832
Part 1: Rename ScriptLoadRequest progress enum to 'State' r=smaug
https://hg.mozilla.org/integration/autoland/rev/20b003843eef
Part 2: Split out script load request state for when we require loading from source r=smaug
https://hg.mozilla.org/integration/autoland/rev/d5a5bb17fea9
Part 3: Add script load request cancelled state r=smaug
https://hg.mozilla.org/integration/autoland/rev/0ea212923238
Part 4: Rename state accessor methods after the enum values r=smaug

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1c5d8b97d832
https://hg.mozilla.org/mozilla-central/rev/20b003843eef
https://hg.mozilla.org/mozilla-central/rev/d5a5bb17fea9
https://hg.mozilla.org/mozilla-central/rev/0ea212923238