1761437 - Language switching and restart causes strange artifacts in tree views for English texts

Status: VERIFIED FIXED

(Core :: Graphics: Text, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: mangled search engines

[Description:]

I've noticed this mostly in localizations that use special chars. Once it happens, I haven't figured a way to restore a readable search engine list - excluding another live language switching.

[Environment:]

100.0a1 (2022-03-24)

Windows 10 / Ubuntu 20
Mac 11 - not reproducible

[Preconditions:]

Configs:

intl.multilingual.downloadEnabled: true
intl.multilingual.enabled: true
intl.multilingual.liveReload: true
browser.search.log: true

Tools:

language packs
search-addon if needed, preferably in a separate FX for default engine checks

[Steps:]

1. Install a firefox Firefox locale, en-us for example (autoset region not that relevant).
2. Install zh-CN language pack from the preconditions.
3. Open about:preferences / Language.
4. Switch the language to zh-cn.
5. Restart Firefox.
6. Open about:preferences#search and check the search engines list.

[Actual Result:]

Engines names contain artefacts. (interemittent, depends on which language the switch change happens to)

[Expected Result:]

Engine names are readable at all times.

[Note:]

This issue might get fixed or altered when bug 1758730 lands.

Comment 1

[Adrian Florinescu [:aflorinescu]]

It's really close to S3, but given that once it happens, the about:preferences#search engine list looks unusable, I'll set S2 for now pending further triage.

Comment 2

[Greg Tatum [:gregtatum]]

Does this reproduce without intl.multilingual.liveReload: true? It sounds like it could be an existing issue.

Comment 3

[Adrian Florinescu [:aflorinescu]]

(In reply to Greg Tatum [:gregtatum] from comment #2)

Does this reproduce without intl.multilingual.liveReload: true? It sounds like it could be an existing issue.

Yes, profiles used for testing use the user.js config from preconditions.

Comment 4

[:Gijs (he/him)]

Handing this to the search team for further triage, as it seems like an issue in the backend of the search engine store (rather than just the prefs use of that code), if this happens after a restart.

Comment 5

[Mark Banner (:standard8)]

I can reproduce this with or without live reload enabled. This only seems to affect Windows, though Linux may also be affected (see bug 1761888).

It also seems to affect tree views specifically.

STR:

1. Have then en-US nightly installed/running.
2. Set intl.multilingual.enabled to true
3. Install the zh-CN language pack from https://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/linux-x86_64/xpi/
4. Open the bookmarks sidebar.
5. Go to Settings -> General and find the language section.
6. At the drop down, select the Chinese language, then click Apply & Restart

Results

English text in the bookmarks sidebar is displayed with strange artifacts.
Settings -> Search -> Search Shortcuts are also displayed with strange artiafacts.

An additional restart fixes them.

The search engine names in other places seem to be displayed correctly, so I don't think this is an issue with the search service. For example, the default engine drop-down on the same settings page and the tooltips on the one-off buttons on the address bar are both displayed correctly.

Comment 6

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1bf5e1ca37463b2342f05ecaa9fdc67da945af6d&tochange=8eb82743e2e4e81e7225bc2f3522f7fcbe5a12eb

Comment 7

[Lee Salzman [:lsalzman]]

I am unable to reproduce this on Linux following the STR. Can you try again on a more recent nightly?

Comment 8

[Jonathan Kew [:jfkthame]]

I can confirm this reproduces for me on Windows with today's Nightly (2022-03-29).

Comment 9

[Lee Salzman [:lsalzman]]

Attachment: Bug 1761437 - Ensure the shared font namespace is allocated by the client. r?gw

The shared font namespace was getting allocated by the RenderBackend, while
we otherwise allocated namespaces for documents on the client. We need to make
sure that if namespace allocation happens on the client, that it also happens
on the client fot the shared font namespace. This adds to RendererOptions to
make passing in a shared font namespace allocated by the client possible.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/806e9fc2d511
Ensure the shared font namespace is allocated by the client. r=gw

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/806e9fc2d511

Comment 12

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 100.0b4 and Nightly 101.0a1 (2022-04-12) on Ubuntu 22.04, Mac 11 and Windows 10.