1761485 - Expose ErrorType through it's own entry point

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P4)

Description

[Beatriz Rizental [:brizental]]

It's kind wierd to have to import a platform specific Glean only to extract the ErrorType export which is exactly the same for all platforms.

Comment 1

[Beatriz Rizental [:brizental]]

To help Mozilla out with this bug, here are the steps:

1. Comment here on the bug that you want to volunteer to help. Someone will assign it to you.
2. Follow the instructions on Glean.js' Getting Started guide to build the library.
3. See how the Uploader or testResetGlean APIs are exposed (https://github.com/mozilla/glean.js/blob/main/glean/package.json#L12-L13). The same pattern should be followed for ErrorType. Once that is done, the ErrorType export should be removed from each of the platforms endpoints i.e. https://github.com/mozilla/glean.js/blob/main/glean/src/entry/node.ts#L8, because it won't be necessary anymore.
4. Update all example on the Glean book the use the deprecated import statement. These are mostly on the metric types reference pages i.e. https://mozilla.github.io/glean/book/reference/metrics/labeled_booleans.html#testgetnumrecordederrors

Comment 2

[tawahpeggy]

Hello Beatriz, I'll like to work on this.

Comment 3

[Alessio Placitelli [:Dexter]]

Hi tawahpeggy ! I've assigned the bug to you. Please follow the instructions in comment 1 to fix this :)

Comment 4

[tawahpeggy]

(In reply to Alessio Placitelli [:Dexter] from comment #3)

Hi tawahpeggy ! I've assigned the bug to you. Please follow the instructions in comment 1 to fix this :)

Alessio thank you, currently on it.

Comment 5

[tawahpeggy]

4. Update all example on the Glean book the use the deprecated import statement. These are mostly on the metric types reference pages i.e. https://mozilla.github.io/glean/book/reference/metrics/labeled_booleans.html#testgetnumrecordederrors.

Hello everyone, I completed points 1 through 3 as stated in comment 1. but I haven't been able to find out how to update the examples on the glean book as I haven't been able to find the piece of code.
please how do edit the book's section: https://mozilla.github.io/glean/book/reference/metrics/labeled_booleans.html#testgetnumrecordederrors?.

Comment 6

[Alessio Placitelli [:Dexter]]

(In reply to tawahpeggy from comment #5)

4. Update all example on the Glean book the use the deprecated import statement. These are mostly on the metric types reference pages i.e. https://mozilla.github.io/glean/book/reference/metrics/labeled_booleans.html#testgetnumrecordederrors.

Hello everyone, I completed points 1 through 3 as stated in comment 1. but I haven't been able to find out how to update the examples on the glean book as I haven't been able to find the piece of code.
please how do edit the book's section: https://mozilla.github.io/glean/book/reference/metrics/labeled_booleans.html#testgetnumrecordederrors?.

Good job :) As you found out, docs are in a separate repository: https://github.com/mozilla/glean/blob/main/docs/user/reference/metrics/labeled_booleans.md

Let's have two PRs for this: one for the bits in the Glean.js repository, the other for the docs changes in the Glean SDKs repository.

Comment 7

[tawahpeggy]

remote: Permission to mozilla/glean.js.git denied to tawahpeggy.
fatal: unable to access 'https://github.com/mozilla/glean.js/': The requested URL returned error: 403

Thanks @Dexter for the heads-up. however,when I try to push, I get this authentication error.

Comment 8

[tawahpeggy]

Hello all, after brainstorming on what could possibly be the reason I am getting an access denied when I try to push,
I resolved to the following.
I couldn't access my Bugzilla account due to 2step authentication some months ago because I lost my phone. After trying to resolve the issue to no avail, I created a new Bugzilla account using a different mail. but now I cannot push because the new email is not attributed to any Github account. please how do I regain my previous account? here is the email: [e-mail]

Comment 9

[Tawah Peggy]

Hello @all, i got to solve the issue by having someone in the bugzilla team remove the 2-step authentication from my previous account. so please someone should please unassign me here and assign this user instead:
username:Tawah Peggy
email: [e-mail]

Comment 10

[Alessio Placitelli [:Dexter]]

(In reply to tawahpeggy from comment #7)

remote: Permission to mozilla/glean.js.git denied to tawahpeggy.
fatal: unable to access 'https://github.com/mozilla/glean.js/': The requested URL returned error: 403

Thanks @Dexter for the heads-up. however,when I try to push, I get this authentication error.

Hey Tawah,

I'm afraid this has nothing to do with Bugzilla and 2FA. You do not have write access to the Glean.js repository, that's normal and ok. You should be sending a PR from a fork, not pushing a new branch to the upstream repository. See these docs for an overview of the contribution process on GitHub.

Comment 11

[tawahpeggy]

(In reply to Alessio Placitelli [:Dexter] from comment #10)

(In reply to tawahpeggy from comment #7)

remote: Permission to mozilla/glean.js.git denied to tawahpeggy.
fatal: unable to access 'https://github.com/mozilla/glean.js/': The requested URL returned error: 403

Thanks @Dexter for the heads-up. however,when I try to push, I get this authentication error.

Hey Tawah,

I'm afraid this has nothing to do with Bugzilla and 2FA. You do not have write access to the Glean.js repository, that's normal and ok. You should be sending a PR from a fork, not pushing a new branch to the upstream repository. See these docs for an overview of the contribution process on GitHub.

okay I understand clearly, it did cross my mind that this could be a possibility but I wasn't sure.thank you.

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean.js/pull/1318

Comment 13

[tawahpeggy]

Hello @all, I have created a pull request,@Dexter please help me review it.

Comment 14

[Alessio Placitelli [:Dexter]]

Reopening since, as the assignee made me notice, this is still lacking docs updates :) Good catch!