1761614 - Fix ESLint rule warnings for no-unused-vars in caps/tests/unit/test_origin.js

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect, P3)

Description

[Akasha]

Steps to reproduce:

• In ESLint config file, remove this line.

• Run ./mach eslint caps/tests/unit/test_origin.js

Actual results:

ESLint gives a no-unused-vars error on the function printAttrs.

55:10  error  'printAttrs' is defined but never used.  no-unused-vars (eslint)

✖ 1 problem (1 error, 0 warnings, 0 fixed)

Expected results:

There should not be any error.

Comment 1

[Akasha]

@standard8 I am working on this but need to clarify the following, please.

printAttrs is a utility function used in debugging.

The lines calling it are commented. Do we uncomment those lines, or do we comment the function printAttrs too?

Or do we configure ESLint to ignore the function printAttrs for the rule no-unused-vars?

Comment 2

[Mark Banner (:standard8)]

(In reply to Akasha from comment #1)

printAttrs is a utility function used in debugging.

The lines calling it are commented. Do we uncomment those lines, or do we comment the function printAttrs too?

Or do we configure ESLint to ignore the function printAttrs for the rule no-unused-vars?

Thanks for asking, I think in this case, as this is a test file, and that's useful for debugging, lets go with ignoring it, i.e. // eslint-disable-next-line no-unused-vars. That'll make it easier if it does get used again.

Comment 3

[Mark Banner (:standard8)]

I'm assigning this to you Akasha as you're working on it.

Comment 4

[Roy Christo]

Hi Akasha, Are you still working on this?

Comment 5

[Mark Banner (:standard8)]

No response, so I'm assuming Akasha isn't working on this. Opening it up for others.

Comment 6

[Brenden Hyde [:bxbrenden] (he/him)]

Attachment: Bug 1761614 - Configure eslint to disable check for unused variable "printAttrs" r=standard8

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a7140adcd96
Configure eslint to disable check for unused variable "printAttrs" r=Standard8 DONTBUILD

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0a7140adcd96