1761635 - switchToTabHavingURI.switchIfURIInWindow should take into account that adoptTab can abort

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Oriol Brufau [:Oriol]]

1. Set browser.urlbar.switchTabs.adoptIntoActiveWindow = true

2. Make sure you don't have any about:preferences tab

3. Open browser console and run

   gBrowser.addTab("about:preferences", {
     createLazyBrowser: true,
     triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal(),
     allowInheritPrincipal: true,
   })
   

4. Open a new window. Open a 2nd tab in it

5. Type about:preferences % in the location bar, choose the entry from the list that says "Switch to Tab".

Then, Firefox tries to adopt the tab into the new window. But this fails due to bug 1758307.

Then, what happens is that the tab closes, but you are still in the new window, not seeing the about:preferences tab anywhere.

I think that if the adoption fails, Firefox should fall back to behaving like with browser.urlbar.switchTabs.adoptIntoActiveWindow = false

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1761635 - Make switchToTabHavingURI handle adoptTab failures. r?Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7bac8f61e16
Make switchToTabHavingURI handle adoptTab failures. r=Gijs

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b7bac8f61e16